From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH v11 8/8] PPC: Don't use hardcoded opcode for ePAPR hcall invocation Date: Mon, 2 Jul 2012 12:34:40 -0500 Message-ID: <4FF1DBB0.1080909@freescale.com> References: <1340395568-29620-1-git-send-email-stuart.yoder@freescale.com> <4FF1D618.5030207@freescale.com> <440F1FF6-267A-452C-9665-274F684A1C93@suse.de> <4FF1D75D.4050507@freescale.com> <8694AAE5-6312-4074-BEA3-2953101890D7@suse.de> <4FF1D988.3040602@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Alexander Graf , Stuart Yoder , , To: Scott Wood Return-path: In-Reply-To: <4FF1D988.3040602@freescale.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Scott Wood wrote: > Hmm. The comment says, "XER, CTR, and LR are currently listed as > clobbers because it's uncertain whether they will be clobbered." Maybe > it dates back to when the ABI was still being discussed? Timur, do you > recall? Nope, sorry. I'm sure we discussed this and looked at the code. My guess is that we weren't certain what the compiler was going to do at the time. I'm still a little confused. Which inline assembly code is clobbering LR? Are you talking about the "BL" instruction, which wasn't there before? -- Timur Tabi Linux kernel developer at Freescale