From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Android-virt] [PATCH v9 16/16] ARM: KVM: Guest wait-for-interrupts (WFI) support Date: Tue, 03 Jul 2012 16:24:24 +0300 Message-ID: <4FF2F288.4020502@redhat.com> References: <20120703085841.27746.82730.stgit@ubuntu> <20120703090212.27746.39517.stgit@ubuntu> <4FF2EF5F.8070207@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Christoffer Dall , tech@virtualopensystems.com, kvm@vger.kernel.org, android-virt@lists.cs.columbia.edu To: Peter Maydell Return-path: Received: from mx1.redhat.com ([209.132.183.28]:57311 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720Ab2GCNYg (ORCPT ); Tue, 3 Jul 2012 09:24:36 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 07/03/2012 04:14 PM, Peter Maydell wrote: > On 3 July 2012 14:10, Avi Kivity wrote: >> Or you could just call kvm_vcpu_block() here without having the >> variable. But eventually you'll need it since you want to expose wfi >> state to userspace for live migration. > > You could just always wake the cpu when migrating: the > architecture allows WFI to return early for any reason > it likes including implementation convenience. Seems reasonable. I imagine wfi works with interrupts disabled, unlike the x86 silliness? -- error compiling committee.c: too many arguments to function