From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH] ehci: Kick async schedule on wakeup in the non companion case Date: Mon, 09 Jul 2012 10:00:21 +0200 Message-ID: <4FFA8F95.3010508@redhat.com> References: <1341586419-32625-1-git-send-email-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Hans de Goede Return-path: Received: from mx1.redhat.com ([209.132.183.28]:23062 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752399Ab2GIIA0 (ORCPT ); Mon, 9 Jul 2012 04:00:26 -0400 In-Reply-To: <1341586419-32625-1-git-send-email-hdegoede@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/06/12 16:53, Hans de Goede wrote: > Commit 0f588df8b3688b00e77aabaa32e26ece5f19bd39, added code > to ehci_wakeup to kick the async schedule on wakeup, but the else > was positioned wrong making it trigger for devices which are routed > to the companion rather then to the ehci controller itself. > > This patch fixes this. Note that the "programming style" with using the > return at the end of the companion block matches how the companion case > is handled in the other ports ops, and is done this way for consistency. Added to usb patch queue. thanks, Gerd