From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read Date: Mon, 09 Jul 2012 15:49:05 +0300 Message-ID: <4FFAD341.3080508@redhat.com> References: <4FFA9E16.10001@linux.vnet.ibm.com> <4FFABD59.2070108@redhat.com> <20120709112346.GA23898@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Xiao Guangrong , Marcelo Tosatti , LKML , KVM To: Gleb Natapov Return-path: In-Reply-To: <20120709112346.GA23898@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/09/2012 02:23 PM, Gleb Natapov wrote: > >> kvm-unit-tests.git has a test for xchg to mmio. Does it still work? >> >> I agree this code has to go, but it needs to be replaced by something. >> Maybe a .valid flag in struct operand. >> > Valid will not enough for that. If we make everything go through operands, any reason why not? -- error compiling committee.c: too many arguments to function