From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dor Laor <dlaor@redhat.com>
Subject: Re: [PATCHv2 kvm] kvm_pv_eoi: add flag support
Date: Tue, 10 Jul 2012 11:39:57 +0300
Message-ID: <4FFBEA5D.7080104@redhat.com>
References: <20120701150830.GA31443@redhat.com>
Reply-To: dlaor@redhat.com
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, avi@redhat.com,
	kvm@vger.kernel.org,
	=?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>,
	Igor Mammedov <imammedo@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Michael Roth <mdroth@linux.vnet.ibm.com>,
	Anthony Liguori <aliguori@us.ibm.com>, gleb@redhat.com
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:14314 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753534Ab2GJIkL (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 10 Jul 2012 04:40:11 -0400
In-Reply-To: <20120701150830.GA31443@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/01/2012 06:08 PM, Michael S. Tsirkin wrote:
> Support the new PV EOI flag in kvm - it recently got merged
> into kvm.git. Set by default with -cpu kvm.
> Set for -cpu qemu by adding +kvm_pv_eoi.
> Clear by adding -kvm_pv_eoi to -cpu option.

What about adding them to our cpu models?
It should go w/o saying for all models (SandyBridge, OpteronGx,..) but 
there is the issue of backward compat. I remember we had a discussion 
about pair the models w/ the current machine type (-M) but I don't 
remember the final call.

What's your take Eduardo?

Cheers,
Dor

>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Changes from v1:
> 	rebased to uq/master
>
>   target-i386/cpu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 5521709..ee1b64a 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -77,7 +77,7 @@ static const char *ext3_feature_name[] = {
>   };
>
>   static const char *kvm_feature_name[] = {
> -    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, NULL, NULL,
> +    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_pv_eoi", NULL,
>       NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>       NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>       NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>