From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 441901F4634; Fri, 10 Jul 2026 05:11:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783660302; cv=none; b=uyyHls/7iQyZhfg6Xf0M9SUuaqnP5hJXKsctBM5YWdlc/djRbNqA7uF2A+I/aueIwzfSItb1Upk4RVivXt8djA0xVwjHWb5KtdUjD9KF3NRoGTDJym9C8ivKOcTzE/QmOVcrUTsdQQteJQyIul290aTvUQG7JxGH73D4M145ddc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783660302; c=relaxed/simple; bh=dME6OgFdwvQ3QIqLtKnDlKNLG71EI67e/Ymtvu9srxw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bVK5WN/Hi6IdsD1AQNEi6l2vfdgfas0IiOutZGhK+1t79lXljN8nST5pheuz9tt5LoaVS13Sb64JlPV2xxr8g3aj9FZwDrxr8c1eyrjzGfGr8CCzKW+/oQ2aa3slN+acLuRnz89Ve7u8EYHTAHf2z4HqBmO2aof3iBz/LxE/8yQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=ph4b7BZG; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="ph4b7BZG" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66A3nZq3075636; Fri, 10 Jul 2026 05:11:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=V70VbE j1ScjUchlU553r0Xd4F46LqK16+8IJ3ntbpQM=; b=ph4b7BZGCLL6yb2U1Xwwcf xa+rUaUVswqAXodKI9w9TNoYs/ySVTgRVV1fS6f4nkR9tq/NE3wz2T21syNHazIc nLpTr2ncrtSfobNuf1flty6Yf8W+cCdO6EhWNYsn4lO9m8o42yL6XmO6hFmnq9O2 WRNNEIN0EEo9LfZfeHgmuYF9YbR053pvpZUPVnGT3WCl7OfHyCFztPlYlaMJvzNe BgOWe6Wt05gIBOFHnSW8U4aSkjudNtu3ZBxqhT990FqyvHDpz1YYg2qwtDE16hDf HFuW3pmBuXRgTcWBoJFyheWmf8/VOcmasL+QaaL1j6UWw6oI26tcOianXAl+bFcQ == Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4f6qknvett-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jul 2026 05:11:24 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66A54Z9L017949; Fri, 10 Jul 2026 05:11:23 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4f7f6yg4x3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jul 2026 05:11:23 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 66A5BJ3246596604 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 10 Jul 2026 05:11:20 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CE2A42004B; Fri, 10 Jul 2026 05:11:19 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EE01820040; Fri, 10 Jul 2026 05:11:16 +0000 (GMT) Received: from [9.124.216.105] (unknown [9.124.216.105]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 10 Jul 2026 05:11:16 +0000 (GMT) Message-ID: <4bea3407-38e1-4d26-8293-7700266a24cf@linux.ibm.com> Date: Fri, 10 Jul 2026 10:41:15 +0530 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 0/6] selftests/vfio: Add sPAPR TCE v2 coverage To: David Matlack Cc: alex@shazbot.org, shuah@kernel.org, amastro@fb.com, rananta@google.com, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, vaibhav@linux.ibm.com, sbhat@linux.ibm.com, harshpb@linux.ibm.com, linuxppc-dev References: <20260703032806.40946-1-nnmlinux@linux.ibm.com> Content-Language: en-US From: Narayana Murty N In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=Q/XiJY2a c=1 sm=1 tr=0 ts=6a507efd cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=VLoToYxrrouXz2LH_DgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=0lgtpPvCYYIA:10 X-Proofpoint-GUID: tAg1fWFAaUvzJjsA7pe8fuK0DQwiFHBu X-Proofpoint-ORIG-GUID: EXTPp-LVbDKqDrGZm3KQsmZ38b284kHs X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDA0MSBTYWx0ZWRfX8izeTpmsTxGu nWVnQNKBO1ZTeDwfFlNjh/cDemT4A9fOmhiQ8N5L6J2GA5RYCSzDY13MTjWaYn5mfwG5LGRLJJ3 Ma8al5MRjZ4kEnQDhT/POgwjEqK9L6Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDA0MSBTYWx0ZWRfX5OyXUVww4uyl 61W4qVO7lzu/jl/O3Up+s4BKNnpmP0crFjUktkccodlVM1cv9RsS2K87kHxJdSAnRY52hyCKEWl /iXdn+yuQII5f8lGieEjL2gUovHi8RFE4sMag570K2TUgiSCn5M9CkkCbVGlSXmWz4Y346agTNm 6njuUR6rLe/8VkbU85/cIIu9Xem7IVzVYvb5WGuumNwr6y9cd9m8zESHnM+vaj3u3HLgMJ0WONf hKH288NfPTN4Xd3m2VY3gnyJxtXI3EC2Rati1VkfYLdyBdVMmiF6ABDqAzIWVTQWF5wG7mtYEnU PrZRMexy/iXL7GLNBOw7xuAO3PRNxbgr45oUvRjmnmdIipyihVhCkFcUfJ5ScnhVIsxU1NwokVW suLbg1mknuUrvIlmabcf6+4xeWm9VIjzUTsolJYFKrqIEof5EAZnqCQydvxhO9fSml7Z2VRsm79 +/1GDXuTBi2bh/BmUbg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_01,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100041 On 09/07/26 9:21 PM, David Matlack wrote: > On Thu, Jul 9, 2026 at 1:49 AM Narayana Murty N wrote: > >>>> Feedback is requested from the VFIO and PowerPC communities on: >>>> 1. whether the sPAPR TCE v2 helpers should remain in the common VFIO >>>> selftest library or move into a sPAPR-specific test helper? >>> Responded in the patch. Let's move to their own file. >> Will do. v2 will have: >> >> lib/iommu_spapr.c — all sPAPR logic, compiled only on powerpc >> lib/iommu_spapr_stub.c — empty stubs returning -EOPNOTSUPP, >> compiled on all other architectures >> lib/include/libvfio/iommu_spapr.h — declarations > Just one small thing here: You can put all the stubs in iommu_spapr.h > as static inlines, then you don't need the extra C file. e.g. > > #ifdef __powerpc__ > > ... prototypes ... > > #else > > ... static inline stubs ... > > #endif Sure, will follow the same. regards, Narayana