From mboxrd@z Thu Jan  1 00:00:00 1970
From: Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH v8 13/28] qmp: add query-sev command
Date: Mon, 12 Feb 2018 12:47:57 -0600
Message-ID: <4dca2760-df74-ca42-ca8d-3462c200a715@amd.com>
References: <20180212153715.87555-1-brijesh.singh@amd.com>
 <20180212153715.87555-14-brijesh.singh@amd.com>
 <e4672dbf-4d1f-3950-aba8-9a52903f35cb@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: brijesh.singh@amd.com,
        Alistair Francis <alistair.francis@xilinx.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Cornelia Huck <cornelia.huck@de.ibm.com>,
        "Daniel P . Berrange" <berrange@redhat.com>,
        "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>,
        Eduardo Habkost <ehabkost@redhat.com>, kvm@vger.kernel.org,
        Marcel Apfelbaum <marcel@redhat.com>,
        Markus Armbruster <armbru@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Peter Crosthwaite <crosthwaite.peter@gmail.com>,
        Peter Maydell <peter.maydell@linaro.org>,
        Richard Henderson <richard.henderson@linaro.org>,
        Stefan Hajnoczi <stefanha@gmail.com>,
        Thomas Lendacky <Thomas.Lendacky@amd.com>,
        Borislav Petkov <bp@su
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-sn1nam02on0043.outbound.protection.outlook.com ([104.47.36.43]:10012
        "EHLO NAM02-SN1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1754052AbeBLSsH (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 12 Feb 2018 13:48:07 -0500
In-Reply-To: <e4672dbf-4d1f-3950-aba8-9a52903f35cb@redhat.com>
Content-Language: en-US
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 2/12/18 11:27 AM, Eric Blake wrote:
> On 02/12/2018 09:37 AM, Brijesh Singh wrote:
>> The QMP query command can used to retrieve the SEV information when
>> memory encryption is enabled on AMD platform.
>>
>> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
>> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>> Cc: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
>> ---
>
>> +# @SevInfo:
>> +#
>> +# Information about Secure Encrypted Virtualization (SEV) support
>> +#
>> +# @enabled: true if SEV is active
>> +#
>> +# @api-major: SEV API major version
>> +#
>> +# @api-minor: SEV API minor version
>> +#
>> +# @build-id: SEV FW build id
>> +#
>> +# @policy: SEV policy value
>> +#
>> +# @state: SEV guest state
>
> Is there a finite list of guest states?
>

Yes, the list is finite.

include/sysemu/sev.h defines the enum

typedef enum {
    SEV_STATE_UNINIT = 0,
    SEV_STATE_LUPDATE,
    SEV_STATE_SECRET,
    SEV_STATE_RUNNING,
    SEV_STATE_SUPDATE,
    SEV_STATE_RUPDATE,
    SEV_STATE_MAX
}


>> +#
>> +# Since: 2.12
>> +##
>> +{ 'struct': 'SevInfo',
>> +    'data': { 'enabled': 'bool',
>> +              'api-major': 'uint8',
>> +              'api-minor' : 'uint8',
>> +              'build-id' : 'uint8',
>> +              'policy' : 'uint32',
>> +              'state' : 'str'
>
> If so, this should be an enum type listing those possible states,
> rather than an open-coded 'str' that can hold anything.
>

If the preference is to return enum, then I can convert the state to
return enum instead of string.