Re: [PATCH v3 01/16] x86/tdx: Move all TDX error defines into

Binbin Wu
2025-09-26T05:36:57Z

On 9/26/2025 7:09 AM, Edgecombe, Rick P wrote:
> On Tue, 2025-09-23 at 13:49 +0800, Binbin Wu wrote:
>>> +/*
>>> + * SW-defined error codes.
>>> + *
>>> + * Bits 47:40 == 0xFF indicate Reserved status code class that never used
>>> by
>>> + * TDX module.
>>> + */
>>> +#define TDX_ERROR _BITULL(63)
>>> +#define TDX_NON_RECOVERABLE _BITULL(62)
>> TDX_ERROR and TDX_NON_RECOVERABLE are defined in TDX spec as the classes of
>> TDX
>> Interface Functions Completion Status.
>>
>> For clarity, is it better to move the two before the "SW-defined error codes"
>> comment?
> This hunk is a direct copy, any reason to change it in this patch?
yeah, it can be done separately.