kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	target-devel <target-devel@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	lf-virt <virtualization@lists.linux-foundation.org>,
	kvm-devel <kvm@vger.kernel.org>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Zhi Yong Wu <wuzhy@cn.ibm.com>,
	Anthony Liguori <aliguori@linux.vnet.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	Hannes Reinecke <hare@suse.de>
Subject: Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6
Date: Wed, 18 Jul 2012 14:12:13 -0500	[thread overview]
Message-ID: <50070A8D.7020203@us.ibm.com> (raw)
In-Reply-To: <1342630038.3022.111.camel@dabdike.int.hansenpartnership.com>

On 07/18/2012 11:47 AM, James Bottomley wrote:
> On Wed, 2012-07-18 at 11:00 -0500, Anthony Liguori wrote:
>
> Of course: Think about the consequences: you want to upgrade one array
> on your SAN.  You definitely don't want to shut down your entire data
> centre to achieve it.  In place upgrades on running SANs have been
> common in enterprise environments for a while.

Would firmware upgrades ever result in major OS visible changes though?

Maybe OSes are more robust with SCSI than with other types of buses, but I don't 
think it's safe to completely ignore the problem.

>> I agree that in general, SCSI targets don't need this, but I'm pretty sure that
>> if a guest probes for a command, you migrate to an old version, and that command
>> is no longer there, badness will ensue.
>
> What command are we talking about?  Operation of initiators is usually
> just READ and WRITE.  So perhaps we might have inline UNMAP ... but the
> world wouldn't come to an end even if the latter stopped working.

Is that true for all OSes?  Linux may handle things gracefully if UNMAP starts 
throwing errors but that doesn't mean that Windows will.

There are other cases where this creates problems.  Windows (and some other 
OSes) fingerprint the hardware profile in order to do license enforcement.  If 
the hardware changes beyond a certain amount, then they refuse to boot.

Windows does this with a points system and I do believe that INQUIRY responses 
from any local disks are included in this tally.

> Most of the complex SCSI stuff is done at start of day; it's actually
> only then we'd notice things like changes in INQUIRY strings or mode
> pages.
>
> Failover, which is what you're talking about, requires reinstatement of
> all the operating parameters of the source/target system, but that's not
> wholly the responsibility of the storage system ...

It's the responsibility of the hypervisor when dealing with live migration.

Regards,

Anthony Liguori

>
> James
>
>> It's different when you're talking about a reboot happening or a
>> disconnect/reconnect due to firmware upgrade.  The OS would naturally be
>> reprobing in this case.
>
>
>

  reply	other threads:[~2012-07-18 19:12 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 21:15 [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6 Nicholas A. Bellinger
2012-07-11 21:15 ` [RFC-v2 1/4] vhost: Separate vhost-net features from vhost features Nicholas A. Bellinger
2012-07-11 21:15 ` [RFC-v2 2/4] vhost: make vhost work queue visible Nicholas A. Bellinger
2012-07-11 21:15 ` [RFC-v2 3/4] vhost: Add vhost_scsi specific defines Nicholas A. Bellinger
2012-07-11 21:15 ` [RFC-v2 4/4] tcm_vhost: Initial merge for vhost level target fabric driver Nicholas A. Bellinger
2012-07-17 15:05 ` [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6 Michael S. Tsirkin
2012-07-17 18:55   ` Anthony Liguori
2012-07-17 19:00     ` Michael S. Tsirkin
2012-07-17 21:50     ` Nicholas A. Bellinger
2012-07-18 13:42       ` Anthony Liguori
2012-07-18 13:56         ` Paolo Bonzini
2012-07-18 15:33         ` Michael S. Tsirkin
2012-07-18 15:53         ` Christoph Hellwig
2012-07-18 16:00           ` Michael S. Tsirkin
2012-07-18 16:42             ` Rustad, Mark D
2012-07-18 17:17               ` Michael S. Tsirkin
2012-07-18 20:12                 ` Rustad, Mark D
2012-07-18 16:00           ` Anthony Liguori
2012-07-18 16:47             ` James Bottomley
2012-07-18 19:12               ` Anthony Liguori [this message]
2012-07-19  6:00                 ` Paolo Bonzini
2012-07-19  7:28                   ` James Bottomley
2012-07-19  7:30                     ` Paolo Bonzini
2012-07-18 22:45         ` Nicholas A. Bellinger
2012-07-17 21:17   ` Nicholas A. Bellinger
2012-07-17 21:34     ` Michael S. Tsirkin
2012-07-17 22:02       ` Nicholas A. Bellinger
2012-07-17 22:18         ` Michael S. Tsirkin
2012-07-17 22:37           ` Nicholas A. Bellinger
2012-07-17 23:11             ` Michael S. Tsirkin
2012-07-18  0:17               ` Nicholas A. Bellinger
2012-07-17 21:58     ` Michael S. Tsirkin
2012-07-17 22:04       ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50070A8D.7020203@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=aliguori@linux.vnet.ibm.com \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=nab@linux-iscsi.org \
    --cc=pbonzini@redhat.com \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=target-devel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wuzhy@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).