From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"Liu, Yi L" <yi.l.liu@intel.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>
Cc: baolu.lu@linux.intel.com, "cohuck@redhat.com" <cohuck@redhat.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"nicolinc@nvidia.com" <nicolinc@nvidia.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"lulu@redhat.com" <lulu@redhat.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
"Zeng, Xin" <xin.zeng@intel.com>,
"Zhao, Yan Y" <yan.y.zhao@intel.com>,
"j.granados@samsung.com" <j.granados@samsung.com>
Subject: Re: [PATCH v8 07/10] iommu/vt-d: Allow qi_submit_sync() to return the QI faults
Date: Mon, 1 Jan 2024 11:34:45 +0800 [thread overview]
Message-ID: <50098edc-2bbb-4c8f-9360-6990f0f5d88a@linux.intel.com> (raw)
In-Reply-To: <BN9PR11MB5276429906ED56258BB433068C9EA@BN9PR11MB5276.namprd11.prod.outlook.com>
On 12/28/23 2:17 PM, Tian, Kevin wrote:
>> raw_spin_lock_irqsave(&qi->q_lock, flags);
>> /*
>> @@ -1430,7 +1439,7 @@ int qi_submit_sync(struct intel_iommu *iommu,
>> struct qi_desc *desc,
>> * a deadlock where the interrupt context can wait
>> indefinitely
>> * for free slots in the queue.
>> */
>> - rc = qi_check_fault(iommu, index, wait_index);
>> + rc = qi_check_fault(iommu, index, wait_index, fault);
>> if (rc)
>> break;
> and as replied in another thread let's change qi_check_fault to return
> -ETIMEDOUT to break the restart loop when fault pointer is valid.
It's fine to break the retry loop when fault happens and the fault
pointer is valid. Please don't forget to add an explanation comment
around the code. Something like:
/*
* The caller is able to handle the fault by itself. The IOMMU driver
* should not attempt to retry this request.
*/
Best regards,
baolu
next prev parent reply other threads:[~2024-01-01 3:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 16:13 [PATCH v8 00/10] Add iommufd nesting (part 2/2) Yi Liu
2023-12-27 16:13 ` [PATCH v8 01/10] iommu: Add cache_invalidate_user op Yi Liu
2023-12-27 16:13 ` [PATCH v8 02/10] iommufd: Add IOMMU_HWPT_INVALIDATE Yi Liu
2023-12-28 6:07 ` Tian, Kevin
2023-12-27 16:13 ` [PATCH v8 03/10] iommu: Add iommu_copy_struct_from_user_array helper Yi Liu
2023-12-27 16:13 ` [PATCH v8 04/10] iommufd/selftest: Add mock_domain_cache_invalidate_user support Yi Liu
2023-12-27 16:13 ` [PATCH v8 05/10] iommufd/selftest: Add IOMMU_TEST_OP_MD_CHECK_IOTLB test op Yi Liu
2023-12-27 16:13 ` [PATCH v8 06/10] iommufd/selftest: Add coverage for IOMMU_HWPT_INVALIDATE ioctl Yi Liu
2023-12-28 6:14 ` Tian, Kevin
2023-12-28 8:32 ` Yi Liu
2023-12-27 16:13 ` [PATCH v8 07/10] iommu/vt-d: Allow qi_submit_sync() to return the QI faults Yi Liu
2023-12-28 6:17 ` Tian, Kevin
2023-12-28 8:33 ` Yi Liu
2024-01-01 3:34 ` Baolu Lu [this message]
2024-01-11 7:14 ` Ethan Zhao
2023-12-27 16:13 ` [PATCH v8 08/10] iommu/vt-d: Convert stage-1 cache invalidation to return QI fault Yi Liu
2023-12-28 6:18 ` Tian, Kevin
2023-12-27 16:13 ` [PATCH v8 09/10] iommufd: Add data structure for Intel VT-d stage-1 cache invalidation Yi Liu
2023-12-28 6:37 ` Tian, Kevin
2023-12-28 6:38 ` Tian, Kevin
2023-12-28 8:35 ` Yi Liu
2023-12-27 16:13 ` [PATCH v8 10/10] iommu/vt-d: Add iotlb flush for nested domain Yi Liu
2023-12-28 7:11 ` Tian, Kevin
2023-12-28 8:42 ` Yi Liu
2023-12-27 20:58 ` [PATCH v8 00/10] Add iommufd nesting (part 2/2) Nicolin Chen
2023-12-28 1:48 ` Yi Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50098edc-2bbb-4c8f-9360-6990f0f5d88a@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=j.granados@samsung.com \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xin.zeng@intel.com \
--cc=yan.y.zhao@intel.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox