From: Scott Wood <scottwood@freescale.com>
To: Bhushan Bharat-R65777 <R65777@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"agraf@suse.de" <agraf@suse.de>
Subject: Re: [PATCH 2/2 v5] KVM: PPC: booke: Add watchdog emulation
Date: Mon, 23 Jul 2012 11:00:44 -0500 [thread overview]
Message-ID: <500D752C.6070904@freescale.com> (raw)
In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D03DD599C@039-SN2MPN1-023.039d.mgd.msft.net>
On 07/23/2012 10:43 AM, Bhushan Bharat-R65777 wrote:
>
>
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Monday, July 23, 2012 9:02 PM
>> To: Bhushan Bharat-R65777
>> Cc: Wood Scott-B07421; kvm-ppc@vger.kernel.org; kvm@vger.kernel.org;
>> agraf@suse.de
>> Subject: Re: [PATCH 2/2 v5] KVM: PPC: booke: Add watchdog emulation
>>
>> On 07/22/2012 11:10 PM, Bhushan Bharat-R65777 wrote:
>>>>> @@ -386,13 +387,23 @@ int kvm_arch_vcpu_init(struct kvm_vcpu *vcpu)
>>>>> #ifdef CONFIG_KVM_EXIT_TIMING
>>>>> mutex_init(&vcpu->arch.exit_timing_lock);
>>>>> #endif
>>>>> -
>>>>> +#ifdef CONFIG_BOOKE
>>>>> + spin_lock_init(&vcpu->arch.wdt_lock);
>>>>> + /* setup watchdog timer once */
>>>>> + setup_timer(&vcpu->arch.wdt_timer, kvmppc_watchdog_func,
>>>>> + (unsigned long)vcpu);
>>>>> +#endif
>>>>> return 0;
>>>>> }
>>>>
>>>> Can you do this in kvmppc_booke_init()?
>>>
>>> I do not think we can do this in kvmppc_booke_init(). Watchdog have
>>> association with vcpu, while there is no vcpu at kvmppc_booke_init().
>>
>> Sorry, I meant kvm_arch_vcpu_setup() in booke.c.
>
> Any specific reason to move this in above mentioned function? Want to avoid #ifdef config_booke ?
Yes, to avoid the ifdef. We already have a (poorly named) place for
booke-specific vcpu init.
-Scott
next prev parent reply other threads:[~2012-07-23 16:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 5:00 [PATCH 2/2 v5] KVM: PPC: booke: Add watchdog emulation Bharat Bhushan
2012-07-20 21:29 ` Scott Wood
2012-07-21 8:37 ` Bhushan Bharat-R65777
2012-07-23 15:35 ` Scott Wood
2012-07-23 4:10 ` Bhushan Bharat-R65777
2012-07-23 15:32 ` Scott Wood
2012-07-23 15:43 ` Bhushan Bharat-R65777
2012-07-23 16:00 ` Scott Wood [this message]
2012-07-23 16:04 ` Bhushan Bharat-R65777
2012-07-23 16:30 ` Scott Wood
2012-07-24 7:45 ` Bhushan Bharat-R65777
2012-07-24 22:32 ` Scott Wood
2012-07-25 20:37 ` Marcelo Tosatti
2012-07-25 23:55 ` Scott Wood
2012-07-26 0:46 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500D752C.6070904@freescale.com \
--to=scottwood@freescale.com \
--cc=B07421@freescale.com \
--cc=R65777@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).