From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: + ppc-e500_tlb-memset-clears-nothing.patch added to -mm tree Date: Wed, 25 Jul 2012 11:32:05 +0300 Message-ID: <500FAF05.8010304@redhat.com> References: <20120724210054.4164420004E@hpza10.eem.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: mm-commits@vger.kernel.org, alan@linux.intel.com, agraf@suse.de, benh@kernel.crashing.org, dcb314@hotmail.com, mtosatti@redhat.com, paulus@samba.org, KVM list To: akpm@linux-foundation.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:18802 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932753Ab2GYIcT (ORCPT ); Wed, 25 Jul 2012 04:32:19 -0400 In-Reply-To: <20120724210054.4164420004E@hpza10.eem.corp.google.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/25/2012 12:00 AM, akpm@linux-foundation.org wrote: > The patch titled > Subject: ppc: e500_tlb memset clears nothing > has been added to the -mm tree. Its filename is > ppc-e500_tlb-memset-clears-nothing.patch > The kvm tree is maintained. Alex, please pick up this patch; I guess it's 3.6 material. > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > The -mm tree is included into linux-next and is updated > there every 3-4 working days > > ------------------------------------------------------ > From: Alan Cox > Subject: ppc: e500_tlb memset clears nothing > > Put the parameters the right way around > > Addresses https://bugzilla.kernel.org/show_bug.cgi?id=44031 > > Reported-by: David Binderman > Signed-off-by: Alan Cox > Cc: Avi Kivity > Cc: Marcelo Tosatti > Cc: Alexander Graf > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Signed-off-by: Andrew Morton > --- > > arch/powerpc/kvm/e500_tlb.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff -puN arch/powerpc/kvm/e500_tlb.c~ppc-e500_tlb-memset-clears-nothing arch/powerpc/kvm/e500_tlb.c > --- a/arch/powerpc/kvm/e500_tlb.c~ppc-e500_tlb-memset-clears-nothing > +++ a/arch/powerpc/kvm/e500_tlb.c > @@ -322,11 +322,11 @@ static inline void kvmppc_e500_ref_relea > static void clear_tlb1_bitmap(struct kvmppc_vcpu_e500 *vcpu_e500) > { > if (vcpu_e500->g2h_tlb1_map) > - memset(vcpu_e500->g2h_tlb1_map, > - sizeof(u64) * vcpu_e500->gtlb_params[1].entries, 0); > + memset(vcpu_e500->g2h_tlb1_map, 0, > + sizeof(u64) * vcpu_e500->gtlb_params[1].entries); > if (vcpu_e500->h2g_tlb1_rmap) > - memset(vcpu_e500->h2g_tlb1_rmap, > - sizeof(unsigned int) * host_tlb_params[1].entries, 0); > + memset(vcpu_e500->h2g_tlb1_rmap, 0, > + sizeof(unsigned int) * host_tlb_params[1].entries); > } > > static void clear_tlb_privs(struct kvmppc_vcpu_e500 *vcpu_e500) > _ > Subject: Subject: ppc: e500_tlb memset clears nothing > -- error compiling committee.c: too many arguments to function