From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 3/5] hotplug: introduce qdev_unplug_ack() to remove device
 from views
Date: Wed, 25 Jul 2012 13:58:48 +0300
Message-ID: <500FD168.3060301@redhat.com>
References: <1343187070-27371-1-git-send-email-qemulist@gmail.com> <1343187070-27371-4-git-send-email-qemulist@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Anthony Liguori <anthony@codemonkey.ws>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>
To: Liu Ping Fan <qemulist@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:31813 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755991Ab2GYK65 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 25 Jul 2012 06:58:57 -0400
In-Reply-To: <1343187070-27371-4-git-send-email-qemulist@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/25/2012 06:31 AM, Liu Ping Fan wrote:
> From: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
> 
> When guest confirm the removal of device, we should
> --unmap from MemoryRegion view
> --isolated from device tree view
> 
> +
> +void qdev_unplug_ack(DeviceState *dev, Error **errp)
> +{
> +    qemu_rwlock_wrlock_devtree();
> +    /* isolate from device tree */
> +    qdev_unset_parent(dev);
> +    /* isolate from mem view */
> +    qdev_unmap(dev);
> +    qemu_rwlock_unlock_devtree();
> +    object_unref(OBJECT(dev));
> +}

Suggest calling in _complete() instead.

-- 
error compiling committee.c: too many arguments to function