From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: emulator: drop unneeded call to get_segment() Date: Thu, 26 Jul 2012 12:21:39 +0300 Message-ID: <50110C23.6070408@redhat.com> References: <20120725124942.GN26120@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mtosatti@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9238 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137Ab2GZJVo (ORCPT ); Thu, 26 Jul 2012 05:21:44 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6Q9LiNX012722 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 26 Jul 2012 05:21:44 -0400 In-Reply-To: <20120725124942.GN26120@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/25/2012 03:49 PM, Gleb Natapov wrote: > setup_syscalls_segments() calls get_segment() and than overwrites all > but one of the structure fields and this one should also be overwritten > anyway, so we can drop call to get_segment() and avoid a couple of vmreads > on vmx. Also drop zeroing ss/cs structures since most of the fields are > set anyway. Just set those that were not set explicitly. > Applied, thanks. -- error compiling committee.c: too many arguments to function