From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/3] KVM: s390: Trace events support. Date: Thu, 26 Jul 2012 12:35:10 +0300 Message-ID: <50110F4E.6030106@redhat.com> References: <1343056830-45290-1-git-send-email-cornelia.huck@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Christian Borntraeger , Carsten Otte , Alexander Graf , Heiko Carstens , Martin Schwidefsky , KVM , linux-s390 To: Cornelia Huck Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40796 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364Ab2GZJfW (ORCPT ); Thu, 26 Jul 2012 05:35:22 -0400 In-Reply-To: <1343056830-45290-1-git-send-email-cornelia.huck@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/23/2012 06:20 PM, Cornelia Huck wrote: > Avi, Marcelo, > > here's a patch set that introduces trace events for kvm/s390. > > It's split into two parts: > > - Trace points for architecture-defined events, like intercepts. > This patch calls into the disassembler via the interface provided > by the first patch. These trace points show up under events/kvm/. > - Trace points for implementation-specific events like interrupt > injection. These show up under a new trace system, kvm-s390. I don't see what's the difference between the two types. Isn't interrupt injection architectural? On x86, the implementation tracepoints are ones that may go away if the implementation changes significantly, while the architectural ones will not go away unless the architecture is changed. In fact creation and destruction of vcpus and reset requests are not only architectural, they're generic, you may as well add them to the arch independent trace code. btw - why are vcpu creation and destruction useful events to trace? -- error compiling committee.c: too many arguments to function