From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: qemu-kvm-1.1.0 crashing with kernel 3.5.0-rc6 Date: Thu, 26 Jul 2012 13:45:57 +0300 Message-ID: <50111FE5.8090801@redhat.com> References: <4FFAB92C.4030001@googlemail.com> <4FFD26B6.8000802@googlemail.com> <20120711071200.GG23898@redhat.com> <4FFD28B9.9040604@googlemail.com> <20120711072255.GH23898@redhat.com> <50031F85.6020908@googlemail.com> <5007FA1C.5080606@googlemail.com> <5007FAD6.2010407@redhat.com> <500850AD.8080504@googlemail.com> <50111369.6020209@googlemail.com> <50111566.5070202@redhat.com> <50111BFB.8080606@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Chris Clayton , Gleb Natapov , "kvm@vger.kernel.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:57790 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751947Ab2GZKqD (ORCPT ); Thu, 26 Jul 2012 06:46:03 -0400 In-Reply-To: <50111BFB.8080606@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/26/2012 01:29 PM, Jan Kiszka wrote: >> It looks like general memory corruption. Is this repeatable? What's >> the guest uptime when it happens (i.e. is it immediate?) >> >> Jan, why are we calling cpu_set_apic_tpr() with kvm_irqchip_in_kernel? > > To sync the userspace state with what the kernel maintains. Will end up > in kvm_apic_set_tpr which does precisely this. We always did, just the > QOM modeling is new. We should move it to the general register synchronization code, there is no reason to do this every exit (though the cost is likely minimal). -- error compiling committee.c: too many arguments to function