From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 3/3] vfio: Enable vfio-pci and mark supported Date: Wed, 01 Aug 2012 09:15:22 +0200 Message-ID: <5018D78A.4040704@web.de> References: <20120801050241.22163.78549.stgit@bling.home> <20120801051821.22163.64385.stgit@bling.home> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig78C92832A25AACF58A3B272D" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, aik@ozlabs.ru To: Alex Williamson Return-path: Received: from mout.web.de ([212.227.15.3]:52066 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753900Ab2HAHP3 (ORCPT ); Wed, 1 Aug 2012 03:15:29 -0400 In-Reply-To: <20120801051821.22163.64385.stgit@bling.home> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig78C92832A25AACF58A3B272D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-08-01 07:18, Alex Williamson wrote: > Signed-off-by: Alex Williamson > --- >=20 > MAINTAINERS | 5 +++++ > configure | 12 ++++++++++++ > hw/i386/Makefile.objs | 1 + > 3 files changed, 18 insertions(+) >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index 2d219d2..9680d69 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -460,6 +460,11 @@ M: Gerd Hoffmann > S: Maintained > F: hw/usb* > =20 > +VFIO > +M: Alex Williamson > +S: Supported > +F: hw/vfio* > + > vhost > M: Michael S. Tsirkin > S: Supported > diff --git a/configure b/configure > index c65b5f6..81108dc 100755 > --- a/configure > +++ b/configure > @@ -143,6 +143,7 @@ attr=3D"" > libattr=3D"" > xfs=3D"" > =20 > +vfio_pci=3D"no" > vhost_net=3D"no" > kvm=3D"no" > gprof=3D"no" > @@ -489,6 +490,7 @@ Haiku) > usb=3D"linux" > kvm=3D"yes" > vhost_net=3D"yes" > + vfio_pci=3D"yes" > if [ "$cpu" =3D "i386" -o "$cpu" =3D "x86_64" ] ; then > audio_possible_drivers=3D"$audio_possible_drivers fmod" > fi > @@ -824,6 +826,10 @@ for opt do > ;; > --disable-guest-agent) guest_agent=3D"no" > ;; > + --disable-vfio-pci) vfio_pci=3D"no" > + ;; > + --enable-vfio-pci) vfio_pci=3D"yes" > + ;; Do we need this level of control? Open question I'm just wondering every time a new feature gets added together with --disable/--enable switches. > *) echo "ERROR: unknown option $opt"; show_help=3D"yes" > ;; > esac > @@ -1112,6 +1118,8 @@ echo " --disable-guest-agent disable building= of the QEMU Guest Agent" > echo " --enable-guest-agent enable building of the QEMU Guest Age= nt" > echo " --with-coroutine=3DBACKEND coroutine backend. Supported option= s:" > echo " gthread, ucontext, sigaltstack, windo= ws" > +echo " --disable-vfio-pci disable vfio pci device assignement s= upport" > +echo " --enable-vfio-pci enable vfio pci device assignment sup= port" > echo "" > echo "NOTE: The object files are built at the place where configure is= launched" > exit 1 > @@ -3072,6 +3080,7 @@ echo "OpenGL support $opengl" > echo "libiscsi support $libiscsi" > echo "build guest agent $guest_agent" > echo "coroutine backend $coroutine_backend" > +echo "VFIO PCI support $vfio_pci" > =20 > if test "$sdl_too_old" =3D "yes"; then > echo "-> Your SDL version is too old - please upgrade to have SDL supp= ort" > @@ -3754,6 +3763,9 @@ case "$target_arch2" in > *) > echo "CONFIG_NO_XEN=3Dy" >> $config_target_mak > esac > +if test "$vfio_pci" =3D "yes" -a "$target_softmmu" =3D "yes" ; then > + echo "CONFIG_VFIO_PCI=3Dy" >> $config_target_mak > +fi Does this already somehow depend on host =3D=3D Linux? If not, you may br= eak the others. > case "$target_arch2" in > i386|x86_64|ppcemb|ppc|ppc64|s390x) > # Make sure the target and host cpus are compatible > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs > index 8c764bb..a2783ef 100644 > --- a/hw/i386/Makefile.objs > +++ b/hw/i386/Makefile.objs > @@ -11,5 +11,6 @@ obj-$(CONFIG_XEN_PCI_PASSTHROUGH) +=3D xen-host-pci-d= evice.o > obj-$(CONFIG_XEN_PCI_PASSTHROUGH) +=3D xen_pt.o xen_pt_config_init.o x= en_pt_msi.o > obj-y +=3D kvm/ > obj-$(CONFIG_SPICE) +=3D qxl.o qxl-logger.o qxl-render.o > +obj-$(CONFIG_VFIO_PCI) +=3D vfio_pci.o > =20 > obj-y :=3D $(addprefix ../,$(obj-y)) >=20 Jan --------------enig78C92832A25AACF58A3B272D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlAY14oACgkQitSsb3rl5xQ6ZwCeOD3ATbDY7NIjZhUvdqDTctFD sTIAniUSbSjR6TGKA81M8XDcd0mV7e1f =/P6a -----END PGP SIGNATURE----- --------------enig78C92832A25AACF58A3B272D--