kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Gleb Natapov <gleb@redhat.com>,
	Joerg Roedel <joerg.roedel@amd.com>,
	Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [RFC PATCH] KVM: Only print vcpu_unimpl when DEBUG is set
Date: Wed, 01 Aug 2012 11:41:19 +0300	[thread overview]
Message-ID: <5018EBAF.9090404@redhat.com> (raw)
In-Reply-To: <20120801031930.GB31711@amt.cnet>

On 08/01/2012 06:19 AM, Marcelo Tosatti wrote:
> On Thu, Jul 26, 2012 at 02:22:48PM +0200, Markus Trippelsdorf wrote:
>> Every time I start qemu-kvm on my system the following line is added to
>> the syslog:
>> 
>>  vcpu0 unhandled rdmsr: 0xc0010001
>> 
>> AFAICS all calls to vcpu_unimpl only contain debugging info with little
>> or no value for the end user.
>> 
>> Wouldn't something like the following patch make sense?
>> 
>> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
> 
> It could be useful for debugging (but then lots of other things could).
> 
> Anyone has a use for this?

The current scenario is:

<guest breaks>
Maintainer asks for dmesg
If something shows up, it's something to consider

Following this patch, the scenario will be

<guest breaks>
Maintainer: please enable dynamic debug for kvm and reproduce
If something shows up, it's something to consider

I guess with dynamic debug it's acceptable, we just need to make sure
that it doesn't spew tons of other stuff.

-- 
error compiling committee.c: too many arguments to function

      reply	other threads:[~2012-08-01  8:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26 12:22 [RFC PATCH] KVM: Only print vcpu_unimpl when DEBUG is set Markus Trippelsdorf
2012-08-01  3:19 ` Marcelo Tosatti
2012-08-01  8:41   ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5018EBAF.9090404@redhat.com \
    --to=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=joerg.roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).