From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 1/3] vfio: Import vfio kernel header Date: Thu, 02 Aug 2012 18:45:56 +0200 Message-ID: <501AAEC4.7000005@web.de> References: <20120801050241.22163.78549.stgit@bling.home> <20120801051807.22163.96305.stgit@bling.home> <5018D713.1050304@web.de> <1343844589.6698.3.camel@bling.home> <501A4240.8050602@web.de> <1343925460.8003.19.camel@ul30vt> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigDD9FC6F83A272AFABD7914EA" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, aik@ozlabs.ru To: Alex Williamson Return-path: Received: from mout.web.de ([212.227.17.11]:50970 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753449Ab2HBQqE (ORCPT ); Thu, 2 Aug 2012 12:46:04 -0400 In-Reply-To: <1343925460.8003.19.camel@ul30vt> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDD9FC6F83A272AFABD7914EA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-08-02 18:37, Alex Williamson wrote: > On Thu, 2012-08-02 at 11:02 +0200, Jan Kiszka wrote: >> On 2012-08-01 20:09, Alex Williamson wrote: >>> On Wed, 2012-08-01 at 09:13 +0200, Jan Kiszka wrote: >>>> On 2012-08-01 07:18, Alex Williamson wrote: >>> >>>>> +#define VFIO_IOMMU_UNMAP_DMA _IO(VFIO_TYPE, VFIO_BASE + 14) >>>>> + >>>>> +#endif /* VFIO_H */ >>>>> >>>> >>>> Please patch update-linux-headers.sh and let it do its work instead >>>> (separate patches). >>> >>> Unfortunately I missed updating the Kbuild file in the kernel, so vfi= o.h >>> doesn't get installed yet. I'll include that in my next pull request= , >>> but maybe in the meantime I should temporarily put this header back i= n >>> hw/ unless you have a better idea. Thanks, >> >> Well, if it's going to be fixed very soon, we can merge it like this. >> But you should already be able provide a patch for the update script s= o >> that the next one running it against a fixed kernel will not >> accidentally drop the vfio header again. >=20 > What's the reason for the rm -fr; mkdir -p in the update script? I > don't see how we'd be unintentionally generating cruft in these > directories if we were to just overwrite files instead of removing the > directory and repopulating it. I'll get the kernel fixed soon, but I'm= > tempted to add vfio and drop the expunge of the directory at the same > time. Thanks, Well, chances to pile up cruft are low, granted. On the other hand, this policy enforces proper upstream header exporting as we see... Jan --------------enigDD9FC6F83A272AFABD7914EA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlAarsYACgkQitSsb3rl5xSJWwCg1Py7eYFYaI6AaH5RIHGVsQMq 2BkAn0kiSM58a3xcyv0K4llLyo1GXhjN =maBY -----END PGP SIGNATURE----- --------------enigDD9FC6F83A272AFABD7914EA--