From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v2] configure: Don't implicitly hardcode
 list of KVM architectures
Date: Sat, 04 Aug 2012 17:29:03 +0200
Message-ID: <501D3FBF.9060209@suse.de>
References: <1343998285-12848-1-git-send-email-peter.maydell@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
	Alexander Graf <agraf@suse.de>, Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>, patches@linaro.org
To: Peter Maydell <peter.maydell@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cantor2.suse.de ([195.135.220.15]:37238 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753199Ab2HDP3K (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 4 Aug 2012 11:29:10 -0400
In-Reply-To: <1343998285-12848-1-git-send-email-peter.maydell@linaro.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Am 03.08.2012 14:51, schrieb Peter Maydell:
> The code creating the symlink from linux-headers/asm to the
> architecture specific linux-headers/asm-$arch directory was
> implicitly hardcoding a list of KVM supporting architectures.
> Add a default case for the common "Linux architecture name and
> QEMU CPU name match" case, so future architectures will only
> need to add code if they've managed to get mismatched names.
>=20
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> v1->v2 changes: conform to same indent rules as surrounding code

Did you send the wrong patch? ;)

Andreas

>=20
>  configure |   14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
>=20
> diff --git a/configure b/configure
> index 9f071b7..eafb81f 100755
> --- a/configure
> +++ b/configure
> @@ -3485,15 +3485,23 @@ if test "$linux" =3D "yes" ; then
>    mkdir -p linux-headers
>    case "$cpu" in
>    i386|x86_64)
> -    symlink "$source_path/linux-headers/asm-x86" linux-headers/asm
> +    linux_arch=3Dx86
>      ;;
>    ppcemb|ppc|ppc64)
> -    symlink "$source_path/linux-headers/asm-powerpc" linux-headers/a=
sm
> +    linux_arch=3Dpowerpc
>      ;;
>    s390x)
> -    symlink "$source_path/linux-headers/asm-s390" linux-headers/asm
> +    linux_arch=3Ds390
> +    ;;
> +  *)
> +    # For most CPUs the kernel architecture name and QEMU CPU name m=
atch.
> +    linux_arch=3D"$cpu"
>      ;;
>    esac
> +    # For non-KVM architectures we will not have asm headers
> +    if [ -e "$source_path/linux-headers/asm-$linux_arch" ]; then
> +      symlink "$source_path/linux-headers/asm-$linux_arch" linux-hea=
ders/asm
> +    fi
>  fi
> =20
>  for target in $target_list; do
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn=
berg