From: Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: mingo@elte.hu, gorcunov@gmail.com, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] kvm tools: inject MSI directly without going through a GSI
Date: Sun, 05 Aug 2012 11:14:19 +0200 [thread overview]
Message-ID: <501E396B.3060700@gmail.com> (raw)
In-Reply-To: <CAOJsxLFY8+Ug2uijyp+4vdSJeUsfRKbiUjgfowKo9sFBb-KO3w@mail.gmail.com>
On 08/05/2012 11:08 AM, Pekka Enberg wrote:
> On 08/04/2012 01:02 PM, Pekka Enberg wrote:
>>> No, it's not running 3.5. We need to support older *host* kernels,
>>> though.
>
> On Sun, Aug 5, 2012 at 10:02 AM, Sasha Levin <levinsasha928@gmail.com> wrote:
>> Do we? Don't we need to support just the kernel that the tool was
>> built with?
>
> We only do that for *guest kernels* if we have to but we've always been
> compatible with older host kernels.
>
> Isn't there a capability flag that KVM sets if KVM_SIGNAL_MSI is
> supported? Just store that in 'struct kvm" and switch between
> virtio_pci__signal_msi() and kvm__irq_trigger() depending on wheter the
> flag is set.
There is, but we've broken backwards compatibility for guests several times before as well - which is why I assumed thats fine.
next prev parent reply other threads:[~2012-08-05 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 14:29 [PATCH 1/2] kvm tools: prevent guest softlockup errors when pausing Sasha Levin
2012-08-02 14:29 ` [PATCH 2/2] kvm tools: inject MSI directly without going through a GSI Sasha Levin
2012-08-04 9:14 ` Pekka Enberg
2012-08-04 9:30 ` Sasha Levin
2012-08-04 11:02 ` Pekka Enberg
2012-08-05 7:02 ` Sasha Levin
2012-08-05 9:08 ` Pekka Enberg
2012-08-05 9:14 ` Sasha Levin [this message]
2012-08-05 9:31 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501E396B.3060700@gmail.com \
--to=levinsasha928@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox