From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v2 02/10] KVM: introduce KVM_PFN_ERR_FAULT
Date: Mon, 06 Aug 2012 16:01:21 +0300
Message-ID: <501FC021.5010609@redhat.com>
References: <501B7F94.7090308@linux.vnet.ibm.com> <501B7FD2.4000305@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <501B7FD2.4000305@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 08/03/2012 10:37 AM, Xiao Guangrong wrote:
> After that, the exported and un-inline function, get_fault_pfn,
> can be removed
> 
> 
> +#define KVM_PFN_ERR_FAULT	(-EFAULT)
> +

IMO this symbol isn't needed, just use -EFAULT (and -EHWPOISON etc.)
directly.  Just document it in hva_to_pfn(), since this isn't an
ordinary -EFAULT (and -ENOENT certainly needs describing).


-- 
error compiling committee.c: too many arguments to function