From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH v2 02/10] KVM: introduce KVM_PFN_ERR_FAULT
Date: Mon, 06 Aug 2012 16:03:53 +0300 [thread overview]
Message-ID: <501FC0B9.30006@redhat.com> (raw)
In-Reply-To: <501FC021.5010609@redhat.com>
On 08/06/2012 04:01 PM, Avi Kivity wrote:
> On 08/03/2012 10:37 AM, Xiao Guangrong wrote:
>> After that, the exported and un-inline function, get_fault_pfn,
>> can be removed
>>
>>
>> +#define KVM_PFN_ERR_FAULT (-EFAULT)
>> +
>
> IMO this symbol isn't needed, just use -EFAULT (and -EHWPOISON etc.)
> directly. Just document it in hva_to_pfn(), since this isn't an
> ordinary -EFAULT (and -ENOENT certainly needs describing).
Okay, I see why you did that, in patch 10.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-06 13:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 7:36 [PATCH v2 01/10] KVM: iommu: fix releasing unmapped page Xiao Guangrong
2012-08-03 7:37 ` [PATCH v2 02/10] KVM: introduce KVM_PFN_ERR_FAULT Xiao Guangrong
2012-08-06 13:01 ` Avi Kivity
2012-08-06 13:03 ` Avi Kivity [this message]
2012-08-03 7:38 ` [PATCH v2 03/10] KVM: introduce KVM_PFN_ERR_HWPOISON Xiao Guangrong
2012-08-03 7:39 ` [PATCH v2 04/10] KVM: introduce KVM_PFN_ERR_BAD Xiao Guangrong
2012-08-03 7:39 ` [PATCH v2 05/10] KVM: inline is_*_pfn functions Xiao Guangrong
2012-08-03 7:40 ` [PATCH v2 06/10] KVM: remove the unused declare Xiao Guangrong
2012-08-03 7:41 ` [PATCH v2 07/10] KVM: introduce KVM_ERR_PTR_BAD_PAGE Xiao Guangrong
2012-08-03 7:42 ` [PATCH v2 08/10] KVM: do not release the error pfn Xiao Guangrong
2012-08-03 7:42 ` [PATCH v2 09/10] KVM: do not release the error page Xiao Guangrong
2012-08-03 7:43 ` [PATCH v2 10/10] KVM: let the error pfn not depend on error code Xiao Guangrong
2012-08-03 19:17 ` [PATCH v2 01/10] KVM: iommu: fix releasing unmapped page Marcelo Tosatti
2012-08-06 13:05 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501FC0B9.30006@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).