From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/8] use jump labels to streamline common APIC configuration Date: Mon, 06 Aug 2012 16:23:21 +0300 Message-ID: <501FC549.2040108@redhat.com> References: <1344171513-4659-1-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mtosatti@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13153 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752612Ab2HFNXY (ORCPT ); Mon, 6 Aug 2012 09:23:24 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q76DNOHb008802 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 6 Aug 2012 09:23:24 -0400 In-Reply-To: <1344171513-4659-1-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/05/2012 03:58 PM, Gleb Natapov wrote: > APIC code has a lot of checks for apic presence and apic HW/SW enable > state. Most common configuration is when each vcpu has in kernel apic > and it is fully enabled. This path series uses jump labels to turn checks > to nops in the common case. Okay, given the perf results, the fact that we can disable this at runtime if needed, and the fact that userspace can already toggle static keys without privileges, I applied the patchset. I don't think we can improve much on the naming issue, so I just let it be. -- error compiling committee.c: too many arguments to function