From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 7/8] KVM: Add page map arch callback Date: Tue, 07 Aug 2012 16:32:42 +0300 Message-ID: <502118FA.1020007@redhat.com> References: <1344337036-22244-1-git-send-email-agraf@suse.de> <1344337036-22244-8-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm-ppc@vger.kernel.org, KVM list , kvmarm@lists.cs.columbia.edu To: Alexander Graf Return-path: In-Reply-To: <1344337036-22244-8-git-send-email-agraf@suse.de> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 08/07/2012 01:57 PM, Alexander Graf wrote: > Some archs need to ensure that their icache is flushed when mapping a new > page. Add a callback to the generic code for an arch to implement any cache > flush logic it may need. > > Signed-off-by: Alexander Graf > --- > virt/kvm/kvm_main.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index d42591d..4e0882d 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -1161,8 +1161,12 @@ static pfn_t hva_to_pfn(unsigned long addr, bool atomic, bool *async, > pfn = get_fault_pfn(); > } > up_read(¤t->mm->mmap_sem); > - } else > + } else { > pfn = page_to_pfn(page[0]); > +#ifdef __KVM_HAVE_ARCH_MAP_PAGE > + kvm_arch_map_page(page[0]); > +#endif > + } > Please call it unconditionally, and have a stub inline ifndef __KVM_HAVE_ARCH_MAP_PAGE. Is this the correct place? Who says the caller of hva_to_pfn() is going to map it? -- error compiling committee.c: too many arguments to function