From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: correctly detect APIC SW state in kvm_apic_post_state_restore() Date: Thu, 09 Aug 2012 12:44:55 +0300 Message-ID: <50238697.1030303@redhat.com> References: <20120808122436.GF3341@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mtosatti@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:14454 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270Ab2HIJo6 (ORCPT ); Thu, 9 Aug 2012 05:44:58 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q799ivTD004748 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 Aug 2012 05:44:58 -0400 In-Reply-To: <20120808122436.GF3341@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/08/2012 03:24 PM, Gleb Natapov wrote: > For apic_set_spiv() to track APIC SW state correctly it needs to see > previous and next values of the spurious vector register, but currently > memset() overwrite the old value before apic_set_spiv() get a chance to > do tracking. Fix it by calling apic_set_spiv() before overwriting old > value. > Applied, thanks. -- error compiling committee.c: too many arguments to function