From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, KVM list <kvm@vger.kernel.org>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 5/8] KVM: Add hva_to_memslot
Date: Thu, 09 Aug 2012 13:36:22 +0300 [thread overview]
Message-ID: <502392A6.7070404@redhat.com> (raw)
In-Reply-To: <20120809193441.f8336b66.yoshikawa.takuya@oss.ntt.co.jp>
On 08/09/2012 01:34 PM, Takuya Yoshikawa wrote:
> On Tue, 7 Aug 2012 12:57:13 +0200
> Alexander Graf <agraf@suse.de> wrote:
>
>> +struct kvm_memory_slot *hva_to_memslot(struct kvm *kvm, hva_t hva)
>> +{
>> + struct kvm_memslots *slots = kvm_memslots(kvm);
>> + struct kvm_memory_slot *memslot;
>> +
>> + kvm_for_each_memslot(memslot, slots)
>> + if (hva >= memslot->userspace_addr &&
>> + hva < memslot->userspace_addr + memslot->npages)
>> + return memslot;
>> +
>> + return NULL;
>> +}
>
> Can't we have two memory slots which contain that hva?
> I thought that's why hva handler had to check all slots.
We can and do. Good catch.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-09 10:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 10:57 [PATCH 0/8] KVM: PPC: E500: Implement MMU Notifiers Alexander Graf
2012-08-07 10:57 ` [PATCH 1/8] KVM: PPC: BookE: Expose remote TLB flushes in debugfs Alexander Graf
2012-08-07 10:57 ` [PATCH 2/8] KVM: PPC: E500: Fix clear_tlb_refs Alexander Graf
2012-08-07 10:57 ` [PATCH 3/8] KVM: PPC: PR: Use generic tracepoint for guest exit Alexander Graf
2012-08-07 10:57 ` [PATCH 4/8] KVM: PPC: Expose SYNC cap based on mmu notifiers Alexander Graf
2012-08-07 10:57 ` [PATCH 5/8] KVM: Add hva_to_memslot Alexander Graf
2012-08-08 4:55 ` [kvmarm] " Christoffer Dall
2012-08-08 17:30 ` Alexander Graf
2012-08-09 10:34 ` Takuya Yoshikawa
2012-08-09 10:36 ` Avi Kivity [this message]
2012-08-09 17:02 ` Alexander Graf
2012-08-12 9:24 ` Avi Kivity
2012-08-12 11:03 ` Alexander Graf
2012-08-12 11:21 ` Avi Kivity
2012-08-12 12:47 ` Alexander Graf
2012-08-07 10:57 ` [PATCH 6/8] KVM: PPC: E500: Implement MMU notifiers Alexander Graf
2012-08-07 13:30 ` Avi Kivity
2012-08-07 13:52 ` Alexander Graf
2012-08-07 14:14 ` Avi Kivity
2012-08-07 14:24 ` Alexander Graf
2012-08-08 3:31 ` Paul Mackerras
2012-08-08 8:03 ` Alexander Graf
2012-08-07 10:57 ` [PATCH 7/8] KVM: Add page map arch callback Alexander Graf
2012-08-07 13:32 ` Avi Kivity
2012-08-07 13:44 ` Alexander Graf
2012-08-07 13:58 ` Avi Kivity
2012-08-07 14:08 ` Alexander Graf
2012-08-07 14:10 ` Avi Kivity
2012-08-07 14:14 ` Alexander Graf
2012-08-07 14:20 ` Avi Kivity
2012-08-07 14:24 ` Alexander Graf
2012-08-07 14:31 ` Avi Kivity
2012-08-07 10:57 ` [PATCH 8/8] KVM: PPC: Add cache flush on page map Alexander Graf
2012-08-07 21:01 ` Scott Wood
2012-08-08 7:59 ` Alexander Graf
2012-08-08 17:31 ` [PATCH 0/8] KVM: PPC: E500: Implement MMU Notifiers Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502392A6.7070404@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).