From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 5/8] KVM: Add hva_to_memslot
Date: Thu, 09 Aug 2012 13:36:22 +0300
Message-ID: <502392A6.7070404@redhat.com>
References: <1344337036-22244-1-git-send-email-agraf@suse.de> <1344337036-22244-6-git-send-email-agraf@suse.de> <20120809193441.f8336b66.yoshikawa.takuya@oss.ntt.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Alexander Graf <agraf@suse.de>, kvm-ppc@vger.kernel.org,
	KVM list <kvm@vger.kernel.org>, kvmarm@lists.cs.columbia.edu
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <20120809193441.f8336b66.yoshikawa.takuya@oss.ntt.co.jp>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 08/09/2012 01:34 PM, Takuya Yoshikawa wrote:
> On Tue,  7 Aug 2012 12:57:13 +0200
> Alexander Graf <agraf@suse.de> wrote:
> 
>> +struct kvm_memory_slot *hva_to_memslot(struct kvm *kvm, hva_t hva)
>> +{
>> +	struct kvm_memslots *slots = kvm_memslots(kvm);
>> +	struct kvm_memory_slot *memslot;
>> +
>> +	kvm_for_each_memslot(memslot, slots)
>> +		if (hva >= memslot->userspace_addr &&
>> +		      hva < memslot->userspace_addr + memslot->npages)
>> +			return memslot;
>> +
>> +	return NULL;
>> +}
> 
> Can't we have two memory slots which contain that hva?
> I thought that's why hva handler had to check all slots.

We can and do.  Good catch.


-- 
error compiling committee.c: too many arguments to function