From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org, mtosatti@redhat.com
Subject: Re: [PATCH] KVM: vmx: restore MSR_IA32_DEBUGCTLMSR after VMEXIT
Date: Sun, 12 Aug 2012 16:22:59 +0300 [thread overview]
Message-ID: <5027AE33.1040408@redhat.com> (raw)
In-Reply-To: <20120812131228.GL3341@redhat.com>
On 08/12/2012 04:12 PM, Gleb Natapov wrote:
> MSR_IA32_DEBUGCTLMSR is zeroed on VMEXIT. Restore it to the correct
> value.
>
> @@ -6222,6 +6222,7 @@ static void atomic_switch_perf_msrs(struct vcpu_vmx *vmx)
> static void __noclone vmx_vcpu_run(struct kvm_vcpu *vcpu)
> {
> struct vcpu_vmx *vmx = to_vmx(vcpu);
> + unsigned long debugctlmsr;
>
> if (is_guest_mode(vcpu) && !vmx->nested.nested_run_pending) {
> struct vmcs12 *vmcs12 = get_vmcs12(vcpu);
> @@ -6261,6 +6262,7 @@ static void __noclone vmx_vcpu_run(struct kvm_vcpu *vcpu)
> vmx_set_interrupt_shadow(vcpu, 0);
>
> atomic_switch_perf_msrs(vmx);
> + debugctlmsr = get_debugctlmsr();
How expensive is this? We may want a follow-on patch to cache it in a
per-cpu variable.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-12 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-12 13:12 [PATCH] KVM: vmx: restore MSR_IA32_DEBUGCTLMSR after VMEXIT Gleb Natapov
2012-08-12 13:22 ` Avi Kivity [this message]
2012-08-12 13:25 ` Gleb Natapov
2012-08-12 13:40 ` Avi Kivity
2012-08-12 17:28 ` Gleb Natapov
2012-08-13 7:55 ` Avi Kivity
2012-08-13 22:07 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5027AE33.1040408@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).