From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC PATCH 0/2] irq destination caching prototype Date: Mon, 13 Aug 2012 12:43:50 +0300 Message-ID: <5028CC56.5060809@redhat.com> References: <1344849408-2697-1-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mst@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46563 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750889Ab2HMJn4 (ORCPT ); Mon, 13 Aug 2012 05:43:56 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7D9htU5023138 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Aug 2012 05:43:55 -0400 In-Reply-To: <1344849408-2697-1-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/13/2012 12:16 PM, Gleb Natapov wrote: > Here is a quick prototype of what we discussed yesterday. This one > caches only MSI interrupts for now. The obvious problem is that not > all interrupts (namely IPIs and MSIs using KVM_CAP_SIGNAL_MSI) use irq > routing table, so they cannot be cached. Missing: switch the uncached path to a work queue, so we don't have to iterate over all vcpus in interrupt context. That isn't trivial; for edge-triggered interrupts we need to ignore zeros (if polarity=0) but for level-triggered interrupts we need them to override the previous setting. But we don't know the trigger mode and polarity at this point. -- error compiling committee.c: too many arguments to function