From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create() Date: Tue, 14 Aug 2012 09:42:59 +0200 Message-ID: <502A0183.4070303@web.de> References: <1344272705-17825-1-git-send-email-peter.maydell@linaro.org> <5029FF4B.8040001@web.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig30D1F6B387ADE94DA9D23850" Cc: Avi Kivity , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org, patches@linaro.org To: Peter Maydell Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig30D1F6B387ADE94DA9D23850 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-08-14 09:40, Peter Maydell wrote: > On 14 August 2012 08:33, Jan Kiszka wrote: >> Either you move both or none. >=20 > OK. >=20 >> KVM_IRQ_LINE is old-style, deprecated, KVM_IRQ_LINE_STATUS (i.e >> injection with feedback to allow lost-tick compensation) is the curren= t >> standard that other archs should pick up. >=20 > Can it be documented in the kernel api.txt then, please? Nobody > is going to use it otherwise... (If I'd been paying attention at the > time I'd have nak'd the qemu patches that added it on the grounds > they were using an undocumented kernel API :-)) The kernel API's documentation has in fact a much younger history than KVM support in QEMU. I think we still need to add quite a few standard IOCTLs to make it complete. Patches always welcome. Jan --------------enig30D1F6B387ADE94DA9D23850 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlAqAYMACgkQitSsb3rl5xQpFgCfU1Gl9ofFuLC+CrISJ1qIwX7B GxQAn26/gv8ddqKn2UnS0N0nGij1CAD8 =Z5LY -----END PGP SIGNATURE----- --------------enig30D1F6B387ADE94DA9D23850--