From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create() Date: Tue, 14 Aug 2012 14:01:14 +0300 Message-ID: <502A2FFA.1080604@redhat.com> References: <1344272705-17825-1-git-send-email-peter.maydell@linaro.org> <5029FF4B.8040001@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Peter Maydell , qemu-devel@nongnu.org, patches@linaro.org, Marcelo Tosatti , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44430 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751942Ab2HNLBV (ORCPT ); Tue, 14 Aug 2012 07:01:21 -0400 In-Reply-To: <5029FF4B.8040001@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 08/14/2012 10:33 AM, Jan Kiszka wrote: > > KVM_IRQ_LINE is old-style, deprecated, KVM_IRQ_LINE_STATUS (i.e > injection with feedback to allow lost-tick compensation) is the current > standard that other archs should pick up. KVM_IRQ_LINE_STATUS may not make sense on all architectures. I don't think we're really deprecating KVM_IRQ_LINE or discouraging its use. It's not like the kernel-allocated memory slot ioctls. -- error compiling committee.c: too many arguments to function