Re: [PATCH 35/38] booke: Added ONE_REG interface for IAC/DAC debug registers

[Scott Wood <scottwood@freescale.com>]

On 08/14/2012 06:47 PM, Alexander Graf wrote:
> 
> On 15.08.2012, at 01:44, Scott Wood wrote:
> 
>> On 08/14/2012 06:04 PM, Alexander Graf wrote:
>>> From: Bharat Bhushan <r65777@freescale.com>
>>>
>>> IAC/DAC are defined as 32 bit while they are 64 bit wide. So ONE_REG
>>> interface is added to set/get them.
>>>
>>> Signed-off-by: Bharat Bhushan <bharat.bhushan@freescale.com>
>>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>> ---
>>> arch/powerpc/include/asm/kvm.h      |   12 ++++++++
>>> arch/powerpc/include/asm/kvm_host.h |   24 ++++++++++++++++-
>>> arch/powerpc/kvm/booke.c            |   48 +++++++++++++++++++++++++++++++++-
>>> arch/powerpc/kvm/booke_emulate.c    |    8 +++---
>>> 4 files changed, 84 insertions(+), 8 deletions(-)
>>
>> Shouldn't this be added to the table in
>> Documentation/virtual/kvm/api.txt section 4.68 (KVM_SET_ONE_REG)?
> 
> Very good point. Bharat, please send a patch to add the reg to the documentation.
> 
>> Oh, and section 4.69 refers to 4.68 as 4.64. :-P  Maybe the section
>> numbering should be removed altogether.
> 
> ... and while at it please also post a patch to fix the numbering mess :). I'd prefer if you just fix the numbers rather than remove them altogether though ;).

The numbering seems to be a recurring problem, and just asking for
trouble in a distributed development environment.  I had to renumber the
MMU API documentation numerous times during its long development, which
was even more fun since the numbering in that area of the documentation
was already broken.

-Scott