From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 35/38] booke: Added ONE_REG interface for IAC/DAC debug registers Date: Tue, 14 Aug 2012 19:06:57 -0500 Message-ID: <502AE821.6080208@freescale.com> References: <1344985483-7440-1-git-send-email-agraf@suse.de> <1344985483-7440-36-git-send-email-agraf@suse.de> <502AE2F4.3040008@freescale.com> <3335089F-6F45-41B9-9D66-C9F687A360A2@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: , KVM list , Bharat Bhushan , Bharat Bhushan To: Alexander Graf Return-path: In-Reply-To: <3335089F-6F45-41B9-9D66-C9F687A360A2@suse.de> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 08/14/2012 06:47 PM, Alexander Graf wrote: > > On 15.08.2012, at 01:44, Scott Wood wrote: > >> On 08/14/2012 06:04 PM, Alexander Graf wrote: >>> From: Bharat Bhushan >>> >>> IAC/DAC are defined as 32 bit while they are 64 bit wide. So ONE_REG >>> interface is added to set/get them. >>> >>> Signed-off-by: Bharat Bhushan >>> Signed-off-by: Alexander Graf >>> --- >>> arch/powerpc/include/asm/kvm.h | 12 ++++++++ >>> arch/powerpc/include/asm/kvm_host.h | 24 ++++++++++++++++- >>> arch/powerpc/kvm/booke.c | 48 +++++++++++++++++++++++++++++++++- >>> arch/powerpc/kvm/booke_emulate.c | 8 +++--- >>> 4 files changed, 84 insertions(+), 8 deletions(-) >> >> Shouldn't this be added to the table in >> Documentation/virtual/kvm/api.txt section 4.68 (KVM_SET_ONE_REG)? > > Very good point. Bharat, please send a patch to add the reg to the documentation. > >> Oh, and section 4.69 refers to 4.68 as 4.64. :-P Maybe the section >> numbering should be removed altogether. > > ... and while at it please also post a patch to fix the numbering mess :). I'd prefer if you just fix the numbers rather than remove them altogether though ;). The numbering seems to be a recurring problem, and just asking for trouble in a distributed development environment. I had to renumber the MMU API documentation numerous times during its long development, which was even more fun since the numbering in that area of the documentation was already broken. -Scott