From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cole Robinson Subject: Re: [PATCH] configure: Add --disable-kvm-options Date: Wed, 15 Aug 2012 09:41:31 -0400 Message-ID: <502BA70B.2020607@redhat.com> References: <1344898189-5842-1-git-send-email-crobinso@redhat.com> <20120815014050.GA14568@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:20532 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751920Ab2HONlc (ORCPT ); Wed, 15 Aug 2012 09:41:32 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7FDfW4e025492 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 Aug 2012 09:41:32 -0400 In-Reply-To: <20120815014050.GA14568@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 08/14/2012 09:40 PM, Marcelo Tosatti wrote: > On Mon, Aug 13, 2012 at 06:49:49PM -0400, Cole Robinson wrote: >> In Fedora, our qemu package is based on qemu-kvm, and we go to convoluted >> lengths to provide a qemu-kvm binary with KVM on by default, but all >> qemu-system-* with KVM off by default (using ./configure --disable-kvm) >> >> For qemu-system*, what we really want is upstream qemu symantics of TCG >> by default, but the opt in option for KVM. CONFIG_KVM_OPTIONS fits the >> bill, so let's expose it through ./configure. This will also simplify >> our packaging for non-x86 KVM. >> >> Signed-off-by: Cole Robinson > > This is another deviation from upstream QEMU included in qemu-kvm, which > means someone else can use/rely on this option. While the goal is to > kill qemu-kvm. > > Please carry it in the RPM, it should not be much trouble do that. > Works for me, thanks. - Cole