From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] KVM: PPC: 440: Implement mtdcrx Date: Thu, 16 Aug 2012 12:11:34 +0300 Message-ID: <502CB946.1030906@redhat.com> References: <1345070546-27513-1-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm-ppc@vger.kernel.org, KVM list To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26308 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754834Ab2HPJLo (ORCPT ); Thu, 16 Aug 2012 05:11:44 -0400 In-Reply-To: <1345070546-27513-1-git-send-email-agraf@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 08/16/2012 01:42 AM, Alexander Graf wrote: > Signed-off-by: Alexander Graf > --- > arch/powerpc/kvm/44x_emulate.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/kvm/44x_emulate.c b/arch/powerpc/kvm/44x_emulate.c > index c8c6157..ea57631 100644 > --- a/arch/powerpc/kvm/44x_emulate.c > +++ b/arch/powerpc/kvm/44x_emulate.c > @@ -28,6 +28,7 @@ > #include "44x_tlb.h" > > #define XOP_MFDCR 323 > +#define XOP_MTDCRX 387 > #define XOP_MTDCR 451 > #define XOP_TLBSX 914 > #define XOP_ICCCI 966 > @@ -84,6 +85,8 @@ int kvmppc_core_emulate_op(struct kvm_run *run, struct kvm_vcpu *vcpu, > > break; > > + case XOP_MTDCRX: > + dcrn = kvmppc_get_gpr(vcpu, ra); > case XOP_MTDCR: It's customary to put a /* fallthrough */ comment to shut down any alarms that may be firing off in readers' minds. -- error compiling committee.c: too many arguments to function