From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 00/19] pci-assign: Refactor for upstream merge Date: Thu, 16 Aug 2012 17:34:51 +0300 Message-ID: <502D050B.9010303@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, Alex Williamson To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51749 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932535Ab2HPOe5 (ORCPT ); Thu, 16 Aug 2012 10:34:57 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 08/16/2012 04:54 PM, Jan Kiszka wrote: > With this series, we are getting very close to obsoleting qemu-kvm. It > refactors hw/device-assignment.c and the associated KVM helper functions > into a form that should allow merging them into QEMU. Once the series is > acceptable for qemu-kvm, I will break out the necessary uq/master > patches and push pci-assign to upstream. > > The major step of this series is to define a regular set of kvm_device_* > services that encapsulate classic (i.e. KVM-based, non-VFIO) device > assignment features and export them to i386 targets only. There will > never be another arch using them, therefore I pushed them into this > corner. Moreover, the device assignment device now makes use of the new > KVM IRQ/MSI routing API and no longer pokes into the internals of that > layer. Finally, I moved the code into hw/kvm/pci-assign.c, dropped the > superfluous configure option and did some basic code cleanups (mostly > coding style) to bring things in shape. > > Note that patch 1 is a simple bug fix that should likely be applied for > qemu-kvm-1.2 independently. > > This series depends on [1] and [2] and QEMU upstream (2b97f88c92) being > merged into qemu-kvm. > > Please review. >>From a quick review it looks ready to merge. Of course I'd appreciate a review from Alex or Michael as well. -- error compiling committee.c: too many arguments to function