From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v8 0/6] kvm: level irqfd support Date: Thu, 16 Aug 2012 19:54:04 +0300 Message-ID: <502D25AC.9000307@redhat.com> References: <20120810223633.809.44188.stgit@bling.home> <20120815142803.GF3068@redhat.com> <1345052191.4683.435.camel@ul30vt.home> <20120815192224.GB5670@redhat.com> <502D1FF4.20506@redhat.com> <20120816163658.GA22518@redhat.com> <502D2247.7060107@redhat.com> <20120816165426.GB22518@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Alex Williamson , gleb@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20120816165426.GB22518@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 08/16/2012 07:54 PM, Michael S. Tsirkin wrote: > On Thu, Aug 16, 2012 at 07:39:35PM +0300, Avi Kivity wrote: >> On 08/16/2012 07:36 PM, Michael S. Tsirkin wrote: >> >> >> What if a level irqfd shares a line with a KVM_IRQ_LINE ioctl? Then an >> >> EOI can de-assert the irqfd source, but the line is kept high by the >> >> last KVM_IRQ_LINE invocation. >> > >> > Exactly. So 1 ID for userspace and 1 for irqfd. >> >> Gaa, this mess belongs in userspace. > > Not sure I understand what you refer to. > > I meant simply > #define KVM_IRQFD_IRQ_SOURCE_ID 1 > request it at kvm init. > > As opposed to using KVM_USERSPACE_IRQ_SOURCE_ID like we do now > for edge. > Does this seem acceptable to you? I meant the pic/ioapic, not this particular bit. -- error compiling committee.c: too many arguments to function