From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v2] kvm-all.c: Move init of
 irqchip_inject_ioctl out of kvm_irqchip_create()
Date: Tue, 21 Aug 2012 12:27:51 +0200
Message-ID: <503362A7.4010106@siemens.com>
References: <1345028893-2388-1-git-send-email-peter.maydell@linaro.org>
	<5033449B.40400@siemens.com>
	<CAFEAcA-FSMPJOPx6Y_WkuNWQ3D2_6giQ+ExLqqmoRECBrev2_A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: "patches@linaro.org" <patches@linaro.org>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <CAFEAcA-FSMPJOPx6Y_WkuNWQ3D2_6giQ+ExLqqmoRECBrev2_A@mail.gmail.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

On 2012-08-21 10:25, Peter Maydell wrote:
> On 21 August 2012 09:19, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2012-08-15 13:08, Peter Maydell wrote:
>>> Move the init of the irqchip_inject_ioctl field of KVMState out of
>>> kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq()
>>> can be used even when no irqchip is created (for architectures
>>> that support async interrupt notification even without an in
>>> kernel irqchip).
> 
>> As it's not yet merged, some late comment: irqchip_inject_ioctl should
>> be renamed as well. irq_inject_ioctl?
> 
> If we're changing it anyway, IIRC Avi didn't like the term "inject"
> here?

Then irq_set_ioctl.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux