From: Sasha Levin <levinsasha928@gmail.com>
To: Jean-Mickael Guerin <jean-mickael.guerin@6wind.com>
Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
mst@redhat.com
Subject: Re: [RFC 2/2] virtio-ring: Allocate indirect buffers from cache when possible
Date: Tue, 28 Aug 2012 14:54:07 +0200 [thread overview]
Message-ID: <503CBF6F.1030406@gmail.com> (raw)
In-Reply-To: <4FE01355.6070909@6wind.com>
On 06/19/2012 07:51 AM, Jean-Mickael Guerin wrote:
>> + if (vq->vring.desc[i].flags& VRING_DESC_F_INDIRECT) {
>> + if (vq->vring.desc[i].len< vq->indirect_alloc_thresh)
> This should be > instead of <, no?
It should, yeah.
Too bad slub doesn't yell at you for doing that.
prev parent reply other threads:[~2012-08-28 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 14:09 [RFC 1/2] virtio-ring: Use threshold for switching to indirect descriptors Sasha Levin
2012-06-18 14:09 ` [RFC 2/2] virtio-ring: Allocate indirect buffers from cache when possible Sasha Levin
2012-06-19 5:51 ` Jean-Mickael Guerin
2012-08-28 12:54 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503CBF6F.1030406@gmail.com \
--to=levinsasha928@gmail.com \
--cc=jean-mickael.guerin@6wind.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).