kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Asias He <asias.hejun@gmail.com>
Cc: Pekka Enberg <penberg@kernel.org>,
	Sasha Levin <levinsasha928@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Cyrill Gorcunov <gorcunov@gmail.com>,
	kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] kvm tools: Export DISPLAY ENV as our default host ip address
Date: Wed, 05 Sep 2012 14:56:48 +0300	[thread overview]
Message-ID: <50473E00.2010809@redhat.com> (raw)
In-Reply-To: <CAFO3S418fWvAqt_mmJmLjs21ay8n+yjR-N5NEdwYnujzOgfv4g@mail.gmail.com>

On 09/05/2012 01:14 PM, Asias He wrote:
> On Wed, Sep 5, 2012 at 5:53 PM, Avi Kivity <avi@redhat.com> wrote:
>> On 09/05/2012 12:46 PM, Asias He wrote:
>>>> Ok.  Then the socat command not only exposes the display to the guest,
>>>> but also to any local process with access to localhost:6000.
>>>
>>> Yes.  It is a trick for people with 'Xorg -nolisten tcp' enabled.
>>
>> Which is hopefully everyone.
> 
> Yup. That's why I want the socat trick ;-d

No, it's horribly insecure.

One option is to generate a temporary keypair and use ssh.  Or you can
make the guest talk to an internal unix-domain socket, tunnel that
through virtio-serial, terminate virtio-serial in lkvm, and direct it
towards the local X socket.  It's more work than exposing X11 via tcp,
but if the user said -nolisten tcp, you must respect it.


-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2012-09-05 11:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24 11:29 [PATCH 1/2] kvm tools: Export DISPLAY ENV as our default host ip address Asias He
2012-08-24 11:29 ` [PATCH 2/2] kvm tools: Mount devpts to /dev/pts Asias He
2012-09-04 13:07 ` [PATCH 1/2] kvm tools: Export DISPLAY ENV as our default host ip address Avi Kivity
2012-09-05  6:03   ` Asias He
2012-09-05  7:56     ` Avi Kivity
2012-09-05  9:19       ` Asias He
2012-09-05  9:29         ` Avi Kivity
2012-09-05  9:46           ` Asias He
2012-09-05  9:53             ` Avi Kivity
2012-09-05 10:14               ` Asias He
2012-09-05 11:56                 ` Avi Kivity [this message]
2012-09-06  3:32                   ` Asias He
2012-09-06  7:59                     ` Avi Kivity
2012-09-10  1:26                       ` Asias He
2012-09-10  8:19                         ` Avi Kivity
2012-09-05  8:00   ` Pekka Enberg
2012-09-05  8:09     ` Ingo Molnar
2012-09-05  9:16       ` Asias He
2012-09-05  9:13     ` Asias He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50473E00.2010809@redhat.com \
    --to=avi@redhat.com \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).