From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
gleb@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 1/2] kvm: Use a reserved IRQ source ID for irqfd
Date: Wed, 05 Sep 2012 17:59:46 +0300 [thread overview]
Message-ID: <504768E2.3020706@redhat.com> (raw)
In-Reply-To: <20120905145153.GA11048@redhat.com>
On 09/05/2012 05:51 PM, Michael S. Tsirkin wrote:
> On Wed, Sep 05, 2012 at 05:35:43PM +0300, Avi Kivity wrote:
>> On 08/22/2012 03:41 AM, Michael S. Tsirkin wrote:
>> >>
>> >> I assumed you were pointing out the level vs edge interaction. If we
>> >> call that a userspace bug, I can just drop this. Thanks,
>> >>
>> >> Alex
>> >
>> > level is userspace bug I think :)
>>
>> I don't see how it's a bug. Suppose we have a vfio device that shares a
>> gsi with an emulated device. The emulated device naturally uses
>> KVM_IRQ_LINE (it has no need to re-sample on ADN), while vfio naturally
>> has to use irqfd.
>
> Absolutely. But vfio needs to use irqfd with the new flag.
> Using existing irqfd for level is a bug.
I see we're not reusing this irq source id for level irqfd. But I think
we should, there's no need for per-gsi irq source id. Plus I'd like to
fix the theoretical bug even if it doesn't bite in practice.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-09-05 14:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 19:28 [PATCH v9 0/2] kvm: level irqfd support Alex Williamson
2012-08-21 19:29 ` [PATCH v9 1/2] kvm: Use a reserved IRQ source ID for irqfd Alex Williamson
2012-08-21 19:58 ` Michael S. Tsirkin
2012-08-21 20:06 ` Alex Williamson
2012-08-21 20:41 ` Michael S. Tsirkin
2012-08-21 21:14 ` Alex Williamson
2012-08-22 0:41 ` Michael S. Tsirkin
2012-08-22 1:34 ` Alex Williamson
2012-09-05 14:35 ` Avi Kivity
2012-09-05 14:51 ` Michael S. Tsirkin
2012-09-05 14:59 ` Avi Kivity [this message]
2012-09-05 15:13 ` Michael S. Tsirkin
2012-09-05 15:22 ` Avi Kivity
2012-09-05 15:28 ` Michael S. Tsirkin
2012-09-05 15:35 ` Avi Kivity
2012-09-05 15:09 ` Michael S. Tsirkin
2012-09-05 15:12 ` Avi Kivity
2012-09-05 15:15 ` Michael S. Tsirkin
2012-09-05 14:46 ` Avi Kivity
2012-09-05 15:07 ` Michael S. Tsirkin
2012-09-05 15:15 ` Avi Kivity
2012-08-21 19:29 ` [PATCH v9 2/2] kvm: On Ack, De-assert & Notify KVM_IRQFD extension Alex Williamson
2012-08-21 20:37 ` Michael S. Tsirkin
2012-08-21 21:11 ` Alex Williamson
2012-08-22 0:14 ` Michael S. Tsirkin
2012-08-22 1:48 ` Alex Williamson
2012-09-05 14:57 ` Avi Kivity
2012-09-17 16:13 ` Alex Williamson
2012-08-22 0:31 ` [PATCH v9 0/2] kvm: level irqfd support Michael S. Tsirkin
2012-08-22 1:28 ` Alex Williamson
2012-08-22 8:25 ` Michael S. Tsirkin
2012-09-17 18:08 ` Alex Williamson
2012-08-22 10:10 ` Michael S. Tsirkin
2012-09-05 14:42 ` Avi Kivity
2012-09-05 14:52 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504768E2.3020706@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).