From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= Subject: Re: [Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs. Date: Thu, 06 Sep 2012 12:28:05 +0200 Message-ID: <50487AB5.8060407@suse.de> References: <1346354435-21685-1-git-send-email-Don@CloudSwitch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Don Slutz , Marcelo Tosatti , Avi Kivity , Eduardo Habkost , Igor Mammedov To: Don Slutz Return-path: Received: from cantor2.suse.de ([195.135.220.15]:54284 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753369Ab2IFK2K (ORCPT ); Thu, 6 Sep 2012 06:28:10 -0400 In-Reply-To: <1346354435-21685-1-git-send-email-Don@CloudSwitch.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 30.08.2012 21:20, schrieb Don Slutz: > This is primarily done so that the guest will think it is running > under vmware when hypervisor=3Dvmware is specified as a property of a > cpu. >=20 > Also allow this to work in accel=3Dtcg mode. >=20 > The new cpu properties hyper_level, hyper_extra, hyper_extra_a, and > hyper_extra_b can be used to further adjust what the guest sees. >=20 > Signed-off-by: Don Slutz > --- > target-i386/cpu.c | 178 +++++++++++++++++++++++++++++++++++++++++++= ++++++++++ > target-i386/cpu.h | 9 +++ > target-i386/kvm.c | 33 ++++++++-- > 3 files changed, 214 insertions(+), 6 deletions(-) Please don't add new CPU command line options without matching QOM properties. There are patch series in the works that convert the CPU definitions to QOM subclasses, the parameters then need to be set on th= e X86CPU object instance. Note that the convention for QOM properties is descriptive-name-with-dashes rather than shortened_abbrev_with_undersco= re. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg