From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs. Date: Thu, 6 Sep 2012 15:00:47 -0400 Message-ID: <5048F2DF.60501@CloudSwitch.Com> References: <1346354435-21685-1-git-send-email-Don@CloudSwitch.com> <50487AB5.8060407@suse.de> <20120906184031.GT6223@otherpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?ISO-8859-1?Q?Andreas_F=E4rber?= , Don Slutz , , , Marcelo Tosatti , Avi Kivity , Igor Mammedov To: Eduardo Habkost Return-path: Received: from hub021-nj-6.exch021.serverdata.net ([206.225.164.222]:57009 "EHLO hub021-nj-6.exch021.serverdata.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759357Ab2IFTAs (ORCPT ); Thu, 6 Sep 2012 15:00:48 -0400 In-Reply-To: <20120906184031.GT6223@otherpad.lan.raisama.net> Sender: kvm-owner@vger.kernel.org List-ID: On 09/06/12 14:40, Eduardo Habkost wrote: > On Thu, Sep 06, 2012 at 12:28:05PM +0200, Andreas F=E4rber wrote: >> Am 30.08.2012 21:20, schrieb Don Slutz: >>> This is primarily done so that the guest will think it is running >>> under vmware when hypervisor=3Dvmware is specified as a property of= a >>> cpu. >>> >>> Also allow this to work in accel=3Dtcg mode. >>> >>> The new cpu properties hyper_level, hyper_extra, hyper_extra_a, and >>> hyper_extra_b can be used to further adjust what the guest sees. >>> >>> Signed-off-by: Don Slutz >>> --- >>> target-i386/cpu.c | 178 ++++++++++++++++++++++++++++++++++++++++= +++++++++++++ >>> target-i386/cpu.h | 9 +++ >>> target-i386/kvm.c | 33 ++++++++-- >>> 3 files changed, 214 insertions(+), 6 deletions(-) >> Please don't add new CPU command line options without matching QOM >> properties. There are patch series in the works that convert the CPU >> definitions to QOM subclasses, the parameters then need to be set on= the >> X86CPU object instance. I found: http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg00587.html Is this the right set? > It seems to be a good idea to wait for the CPU properties series from > Igor to be applied, before implementing this. It should make the new > code much simpler. So Igor has a patch set that does a similar change like above. I so fa= r=20 have not found it on QEMU-DEVEL. Please provide a pointer to this patc= h=20 set. > >> Note that the convention for QOM properties is >> descriptive-name-with-dashes rather than shortened_abbrev_with_under= score. >> I will be re-working this change, and wait (for v2) until master has=20 changed to the new way. -Don