From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/3] update kvm related the head file from kernel
Date: Fri, 07 Sep 2012 17:39:20 +0800
Message-ID: <5049C0C8.3060106@linux.vnet.ibm.com>
References: <1347006389-543-1-git-send-email-liusheng@linux.vnet.ibm.com> <1347006389-543-3-git-send-email-liusheng@linux.vnet.ibm.com> <5049B523.8090303@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Liu Sheng <liusheng@linux.vnet.ibm.com>, kvm@vger.kernel.org,
	avi@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org,
	aliguori@us.ibm.com
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e23smtp04.au.ibm.com ([202.81.31.146]:34899 "EHLO
	e23smtp04.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752607Ab2IGJjb (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 7 Sep 2012 05:39:31 -0400
Received: from /spool/local
	by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <kvm@vger.kernel.org> from <xiaoguangrong@linux.vnet.ibm.com>;
	Fri, 7 Sep 2012 19:37:19 +1000
Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])
	by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q879UM2n12583124
	for <kvm@vger.kernel.org>; Fri, 7 Sep 2012 19:30:22 +1000
Received: from d23av03.au.ibm.com (loopback [127.0.0.1])
	by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q879dN1S011778
	for <kvm@vger.kernel.org>; Fri, 7 Sep 2012 19:39:24 +1000
In-Reply-To: <5049B523.8090303@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi Jan,

Thanks for your review.

On 09/07/2012 04:49 PM, Jan Kiszka wrote:

>> +#ifdef __KVM_HAVE_READONLY_MEM
>> +			__u8 write_readonly_mem;
>> +#endif
>>  		} mmio;
>>  		/* KVM_EXIT_HYPERCALL */
>>  		struct {
>> @@ -618,6 +625,9 @@ struct kvm_ppc_smmu_info {
>>  #define KVM_CAP_PPC_GET_SMMU_INFO 78
>>  #define KVM_CAP_S390_COW 79
>>  #define KVM_CAP_PPC_ALLOC_HTAB 80
>> +#ifdef __KVM_HAVE_READONLY_MEM
>> +#define KVM_CAP_READONLY_MEM 81
>> +#endif
> 
> Sorry for commenting on the wrong patch, this must be fixed in the
> kernel: no more conditional CAPs, please. 

There are some common code depend on KVM_CAP_READONLY_MEM, such as,
check_memory_region_flags() and write_readonly_mem field in mmio-exit-info.

Yes, we can use #ifdef CONFIG_X86 to enable it only on x86, but it
is hard to expand this feather to other arches in the further.

So, i used __KVM_HAVE_READONLY_MEM and only defined it on x86. :)