From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 3/3] support readonly memory feature in qemu Date: Mon, 10 Sep 2012 11:25:38 +0200 Message-ID: <504DB212.3000908@siemens.com> References: <1347006389-543-1-git-send-email-liusheng@linux.vnet.ibm.com> <1347006389-543-4-git-send-email-liusheng@linux.vnet.ibm.com> <5049B56B.20707@siemens.com> <504CB9B3.8010408@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Liu Sheng , "kvm@vger.kernel.org" , "mtosatti@redhat.com" , "xiaoguangrong@linux.vnet.ibm.com" , "qemu-devel@nongnu.org" , "aliguori@us.ibm.com" To: Avi Kivity Return-path: Received: from thoth.sbs.de ([192.35.17.2]:26221 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754716Ab2IJJZz (ORCPT ); Mon, 10 Sep 2012 05:25:55 -0400 In-Reply-To: <504CB9B3.8010408@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2012-09-09 17:45, Avi Kivity wrote: > On 09/07/2012 11:50 AM, Jan Kiszka wrote: >> >>> + } else { >>> + cpu_physical_memory_rw(run->mmio.phys_addr, >>> + run->mmio.data, >>> + run->mmio.len, >>> + run->mmio.is_write); >>> + } >>> + >>> ret = 0; >>> break; >>> case KVM_EXIT_IRQ_WINDOW_OPEN: >>> >> >> Great to see this feature for KVM finally! I'm just afraid that this >> will finally break good old isapc - due to broken Seabios. KVM used to >> "unbreak" it as it didn't respect write protections. ;) > > Can you describe the breakage? Try "qemu -machine isapc [-enable-kvm]". Seabios is writing to some read-only marked area. Don't recall where precisely. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux