Re: [RFC PATCH v3 12/19] Implement "info memory-total" and "query-memory-total"

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

On 09/21/2012 05:17 AM, Vasilis Liaskovitis wrote:
> Returns total physical memory available to guest in bytes, including hotplugged
> memory. Note that the number reported here may be different from what the guest
> sees e.g. if the guest has not logically onlined hotplugged memory.
> 
> This functionality is provided independently of a balloon device, since a
> guest can be using ACPI memory hotplug without using a balloon device.
> 
> Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>

> +++ b/hmp-commands.hx
> @@ -1464,6 +1464,8 @@ show qdev device model list
>  show roms
>  @item info memory-hotplug
>  show memory-hotplug
> +@item info memory-total
> +show memory-total

> +++ b/monitor.c
> @@ -2747,6 +2747,13 @@ static mon_cmd_t info_cmds[] = {
>          .mhandler.info = hmp_info_memory_hotplug,
>      },
>      {
> +        .name       = "memory-total",

We're split on HMP naming conventions ('-' vs. '_'); we have 'show
migrate_capabilities' but 'show block-jobs'.  Oh well, that's life.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]