From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
"Roedel, Joerg" <Joerg.Roedel@amd.com>
Subject: Re: [PATCH v2] KVM: x86: Fix guest debug across vcpu INIT reset
Date: Sun, 23 Sep 2012 15:01:16 +0200 [thread overview]
Message-ID: <505F081C.7050807@redhat.com> (raw)
In-Reply-To: <505BE23F.5090200@web.de>
On 09/21/2012 06:42 AM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> If we reset a vcpu on INIT, we so far overwrote dr7 as provided by
> KVM_SET_GUEST_DEBUG, and we also cleared switch_db_regs unconditionally.
>
> Fix this by saving the dr7 used for guest debugging and calculating the
> effective register value as well as switch_db_regs on any potential
> change. This will change to focus of the set_guest_debug vendor op to
> update_dp_bp_intercept.
>
> Found while trying to stop on start_secondary.
>
Thanks, applied.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2012-09-23 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 19:38 [PATCH] KVM: x86: Fix guest debug across vcpu INIT reset Jan Kiszka
2012-09-20 11:39 ` Avi Kivity
2012-09-21 3:42 ` [PATCH v2] " Jan Kiszka
2012-09-23 13:01 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505F081C.7050807@redhat.com \
--to=avi@redhat.com \
--cc=Joerg.Roedel@amd.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).