From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip Date: Thu, 04 Oct 2012 11:28:17 +0200 Message-ID: <506D56B1.8090804@web.de> References: <20121003105255.972669952@amt.cnet> <20121003105509.391284251@amt.cnet> <87fw5vhb5a.fsf@codemonkey.ws> <20121003150341.GA15164@amt.cnet> <506C5DED.7000705@web.de> <878vbn4gs9.fsf@codemonkey.ws> <506C74E0.8080409@web.de> <20121003182652.GA32381@amt.cnet> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB3F570786E060CD7BF403D9F" Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org, Gerd Hoffmann To: Marcelo Tosatti Return-path: Received: from mout.web.de ([212.227.15.4]:60615 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753929Ab2JDJ3F (ORCPT ); Thu, 4 Oct 2012 05:29:05 -0400 In-Reply-To: <20121003182652.GA32381@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB3F570786E060CD7BF403D9F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-10-03 20:26, Marcelo Tosatti wrote: > On Wed, Oct 03, 2012 at 07:24:48PM +0200, Jan Kiszka wrote: >> On 2012-10-03 19:16, Anthony Liguori wrote: >>> Jan Kiszka writes: >>> >>>> On 2012-10-03 17:03, Marcelo Tosatti wrote: >>>>> On Wed, Oct 03, 2012 at 09:40:17AM -0500, Anthony Liguori wrote: >>>>>> Marcelo Tosatti writes: >>>>>> >>>>>>> Commit 3ad763fcba5bd0ec5a79d4a9b6baeef119dd4a3d from qemu-kvm.git= =2E >>>>>>> >>>>>>> From: Jan Kiszka >>>>>>> =20 >>>>>>> Upstream is moving towards this mechanism, so start using it in q= emu-kvm >>>>>>> already to configure the specific defaults: kvm enabled on, just = like >>>>>>> in-kernel irqchips. >>>>>>> >>>>>>> Signed-off-by: Marcelo Tosatti >>>>>> >>>>>> >>>>>> Reviewed-by: Anthony Liguori >>>>>> >>>>>> Although it's a little odd to have From: Jan without a SoB... >>>>> >>>>> Agree, Jan can you ACK? >>>> >>>> I wasn't able to join the call yesterday: Is there a removal schedul= e >>>> associated with those switches? Also, why pushing things upstream, e= ven >>>> when only for one release, that have been loudly deprecated for a wh= ile >>>> in qemu-kvm? Some switches are lacking deprecated warnings on the >>>> console, and -no-kvm is missing completely. I tend to focus on patch= 1 & >>>> 5, dropping the rest - based on relevance for production use. >>> >>> The distros need to keep these flags to do the switch. >> >> Why? Should be documented in commit log. >> >>> I see no point >>> in deprecating them since they're trivially easy to maintain. >> >> Given the level of cr** we already have in the command line, they are >> kind of noise, yes. But even then, these patches are not consistent as= >> pointed out above. >> >> Also, they should not be documented to avoid being spread. That's what= >> we did with other deprecated switches in QEMU. >> >> Jan >=20 > Jan, >=20 > You're comments to the patch are: >=20 > - No documentation. See e.g. how -M is handled in qemu-options.hx. > - Expiration date. Anthony said "forever", but I think we should remove all those that issue deprecation warnings after 1-2 years. > - Changelog explaining what?? (didnt get that). Perhaps better changelo= g > in general? I'm still failing to understand who could depend on -no-kvm-irqchip or -no-kvm-pit. And I don't understand why -no-kvm was not included. Soe the reasons for include -X should be provided. Also check your patch subjects again, at least one was wrong. Jan --------------enigB3F570786E060CD7BF403D9F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlBtVrMACgkQitSsb3rl5xTiiACfcVeZQtz0ijDes6GFtqCRJBxo qnEAn3f5qGog6vw9s3cWv46LMEEsbJY9 =85pD -----END PGP SIGNATURE----- --------------enigB3F570786E060CD7BF403D9F--