From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip Date: Thu, 04 Oct 2012 18:40:47 +0200 Message-ID: <506DBC0F.6090806@siemens.com> References: <20121003105255.972669952@amt.cnet> <20121003105509.391284251@amt.cnet> <87fw5vhb5a.fsf@codemonkey.ws> <20121003150341.GA15164@amt.cnet> <506C5DED.7000705@web.de> <878vbn4gs9.fsf@codemonkey.ws> <506C74E0.8080409@web.de> <20121003182652.GA32381@amt.cnet> <506D56B1.8090804@web.de> <87626qiahv.fsf@codemonkey.ws> <506D9D82.2090202@siemens.com> <506DAD06.1030803@suse.de> <506DB38F.4010704@siemens.com> <506DB5BC.3070901@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Anthony Liguori , Marcelo Tosatti , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , Gerd Hoffmann To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Return-path: Received: from thoth.sbs.de ([192.35.17.2]:16337 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933434Ab2JDQlV (ORCPT ); Thu, 4 Oct 2012 12:41:21 -0400 In-Reply-To: <506DB5BC.3070901@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 2012-10-04 18:13, Andreas F=E4rber wrote: > Am 04.10.2012 18:04, schrieb Jan Kiszka: >> On 2012-10-04 17:36, Andreas F=E4rber wrote: >>> Am 04.10.2012 16:30, schrieb Jan Kiszka: >>>> On 2012-10-04 16:21, Anthony Liguori wrote: >>>> - avoid adding them to the help or other user documentation >>> >>> That's dangerous - at some point someone will notice and propose a = patch >>> documenting them and the reviewers may have forgotten by then why i= t was >>> not documented in the first place. Better clearly document them in = help >>> output as "DEPRECATED, to be removed in future versions" or so. >> >> -M is marked as deprecated in the file that you would have to mess u= p. >=20 > If it's not within +/- 3 lines and goes through qemu-trivial then tha= t > point is moot. Don't see how deprecation of -no-kvm-irqchip et al. is > related to -M being deprecated either way. I'm only citing an example that these switches should follow: [qemu-options.hx] HXCOMM Deprecated by -machine DEF("M", HAS_ARG, QEMU_OPTION_M, "", QEMU_ARCH_ALL) Jan --=20 Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux